Skip to content

[Issue #461] Added timedelta as a diviser option for Timemedeltaseries #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

muddi900
Copy link
Contributor

@muddi900 muddi900 commented Dec 9, 2022

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Something you have done has messed up formatting. Be sure to do poetry run poe style before you commit.
  2. Please add a test. YOu can add it right after this line by just reversing the arguments:
    check(assert_type(td / md_timedelta_series, "pd.Series[float]"), pd.Series, float)

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jan 3, 2023

@muddi900 are you going to be able to finish this?

@muddi900
Copy link
Contributor Author

muddi900 commented Jan 4, 2023 via email

@muddi900
Copy link
Contributor Author

muddi900 commented Jan 4, 2023

So the original issue has already been closed in another PR(#488), so there would be no point in continuing this.

@muddi900 muddi900 closed this Jan 4, 2023
@muddi900 muddi900 deleted the timedelta-divide branch January 4, 2023 07:56
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jan 4, 2023

So the original issue has already been closed in another PR(#488), so there would be no point in continuing this.

Thanks for picking that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dividing a series of Timedeltas by a Timedelta is rejected
2 participants