GH128 Multiple removal of old stubs, unimplement methods using stubtest #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Dr-Irv merged 2 commits into pandas-dev:main from loicdiridollou:gh128_cleanup

May 18, 2025

Member

loicdiridollou commented May 17, 2025

Closes CLEAN: Reconcile types in pandas._typing.py and pandas-stubs._typing.pyi #128 (partial)
Tests added: Please use assert_type() to assert the type of any return value


          GH128 Multiple removal of old stubs, unimplement methods using stubtest

81c5109

Member Author

loicdiridollou commented May 17, 2025

I ran poetry run poe stubtest and clean up some of the items: mostly arguments defaults misspecified, functions/attribute/property that do not exist anymore.

loicdiridollou commented

View reviewed changes

pandas-stubs/io/formats/style.pyi Show resolved Hide resolved

loicdiridollou commented

View reviewed changes

pandas-stubs/io/sql.pyi Show resolved Hide resolved

loicdiridollou commented

View reviewed changes

pandas-stubs/tseries/frequencies.pyi Show resolved Hide resolved

loicdiridollou commented

View reviewed changes

pandas-stubs/util/_tester.pyi Outdated Show resolved Hide resolved

loicdiridollou commented

View reviewed changes

pandas-stubs/util/_validators.pyi Show resolved Hide resolved

Dr-Irv requested changes

View reviewed changes

Collaborator

Dr-Irv left a comment

thanks for doing this. It picked up some good things and things we ought to change.

pandas-stubs/io/sql.pyi Show resolved Hide resolved

pandas-stubs/io/sql.pyi Outdated Show resolved Hide resolved

pandas-stubs/tseries/frequencies.pyi Show resolved Hide resolved

pandas-stubs/io/formats/style.pyi Show resolved Hide resolved

pandas-stubs/util/_tester.pyi Outdated Show resolved Hide resolved

pandas-stubs/util/_validators.pyi Show resolved Hide resolved


          GH128 PR feedback

ef4eeeb

Dr-Irv approved these changes

View reviewed changes

Collaborator

Dr-Irv left a comment

thanks @loicdiridollou

Dr-Irv merged commit 8607315 into pandas-dev:main

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet