Skip to content

Review expected failures #217

Closed
Closed
@Dr-Irv

Description

@Dr-Irv

In #213 @twoertwein marked typing tests that we expect to fail using TYPE_CHECKING_INVALID_USAGE . The idea here is that we are testing code that we want the type checkers to pick up as being incorrect. In many cases, pyright does figure that out. mypy figures it out sometimes, and there are occasions where both type checkers see what we expect to fail as "correct" code.

At some point in time in the past, when the stubs were in the Microsoft repository, those tests were doing the "right" thing, i.e., both type checkers were marking those tests as "failures", and the # type: ignore comments were correct, in the sense that the type checkers saw that they were correct ignores.

Now, possibly due to changes in the settings used for mypy and pyright, as well as evolutions in the type checkers themselves, those tests are no longer failing as we expect them to. Some investigation is required to determine whether this is due to something changing in the stubs, or to particular settings in the type checkers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions