refactor(series)!: ⏱️ drop TimedeltaSeries #1273

cmp0xff · 2025-07-12T19:07:08Z

Addresses CLEAN: Investigate whether TimestampSeries, TimedeltaSeries, etc. can be removed #718
- remaining tasks: remove PeriodSeries, OffsetSeries, IntervalSeries
Tests added: Please use assert_type() to assert the type of any return value

tests/test_timefuncs.py

tests/test_series.py

tests/test_frame.py

pandas-stubs/core/series.pyi

pandas-stubs/core/indexes/accessors.pyi

loicdiridollou

Overall this is a lot of great work, I have taken a crack at it and was quickly under water with the amount of changes needed.
I believe the __add__ issue that you have seems similar to what I am experiencing with #1098 and you may have the same problem with __sub__ and __truediv__ but you will be able to confirm.
I think we can't let those slip in the current version. Maybe the option is to keep the current TimestampSeries definition as a middle layer and start supporting the Series[Timestamp] along the way (not sure if this is possible).

pandas-stubs/core/tools/datetimes.pyi

pandas-stubs/core/series.pyi

tests/test_series.py

tests/test_timefuncs.py

twoertwein

Thank you for working on this!

(It might be too late for that, but it could be nice to split timedelta and timestamp into separate MRs.)

Overload order can be important when we have Series[Any] or Series[unknown]. After you get feedback from @Dr-Irv, it might be nice to add new tests for overloads that might have changed their any/unknown behavior.

pandas-stubs/core/indexes/accessors.pyi

pandas-stubs/core/series.pyi

tests/test_series.py

…3 (review)

cmp0xff · 2025-07-13T07:03:32Z

(It might be too late for that, but it could be nice to split timedelta and timestamp into separate MRs.)

I managed to isolate #1274 which just removes TimestampSeries. This PR can be reviewed after #1274.

…3 (review)

Dr-Irv · 2025-07-24T21:24:01Z

So with this being dependent on #1274, I won't review this until that one is accepted and merged in.

* refactor: only drop TimestampSeries #1273 (review) * fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1274/files#r2229555145 * less mypy ignore * fix: even less mypy ignores * refactor(comment): https://github.com/pandas-dev/pandas-stubs/pull/1274/files#r2229550572 * feat: sub * fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1274/files#r2229581983 * fix: pyrefly * fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1274/files#r2229580369 * fix(comment): #1274 (comment) * fix(comment): #1274 (comment) * fix(comment): #1274 (comment) * fix: reduce ignore * refactor: explain a temporary failure * fix(comment): #1274 (comment) * feat: arithmetic sub * fix(comment): #1312 (comment) * feat(comment): #1312 (comment) * fix(comment): completeness #1312 (review) * feat(series): arithmetic mul * fix: type asserts * feat: tests for addition * fix(mypy): attempt for python > 310 * feat: tests for subtraction * fix: pyright * fix(comment): #1274 (comment) * refactor: revert unused design * feat: progressive philosophy * fix(pytest): remove invalid tests * fix: comment * fix(comment): https://github.com/pandas-dev/pandas-stubs/pull/1274/files/f855f8655fcbc0c13879f404926034621641bc58#r2291133305 * fix(comment): #1274 (comment) * chore(philosophy): first draft * fix(pyright): median * fix: comment * fix(comment): #1274 (review) * fix(comment): test_sub * fix: typo

cmp0xff · 2025-09-24T20:26:15Z

/pandas_nightly

@Dr-Irv I've finished it from my point of view. There are a lot of changes. How do we proceed? I also added Indexes to __mul__, __truediv__ and __floordiv__ because they already exist in the original TimedeltaSeries.

Dr-Irv · 2025-09-24T20:34:23Z

@Dr-Irv I've finished it from my point of view. There are a lot of changes. How do we proceed? I also added Indexes to __mul__, truedivandfloordivbecause they already exist in the originalTimedeltaSeries`.

I'll review it and we'll take it from there.

Dr-Irv

This is looking pretty good. I would have preferred the changes for supporting floordiv and truediv, etc., that don't depend on Timedelta to be in a separate PR, but given how close this is to working, I don't want to add extra work for you.

Can you create an issue in pandas-stubs to create tests for arithmetic for TimedeltaIndex and DatetimeIndex, which should mirror the tests for pd.Series[Timedelta] and pd.Series[Timestamp], respecitvely?

pandas-stubs/_libs/tslibs/timestamps.pyi

pandas-stubs/core/indexes/datetimes.pyi

tests/series/arithmetic/timedelta/test_floordiv.py

tests/series/arithmetic/timedelta/test_truediv.py

tests/series/test_series.py

tests/test_natype.py

pandas-stubs/core/series.pyi

Dr-Irv · 2025-09-25T15:32:50Z

pandas-stubs/core/series.pyi

        numeric_only: _bool = False,
        **kwargs: Any,
-    ) -> float: ...
+    ) -> S1: ...


This isn't entirely correct, because pd.Series([1,2,3,4]).median() returns a float

pandas-stubs/core/series.pyi

Dr-Irv

Only a few things

tests/series/test_agg.py

ttest.py

pandas-stubs/core/series.pyi

Dr-Irv

figured out the to_numpy issue with mypy.

Would rather have median, mean and std return float on untyped Series as it is more user friendly that way.

pandas-stubs/core/series.pyi

pandas-stubs/_typing.pyi

pandas-stubs/core/series.pyi

Dr-Irv

thanks @cmp0xff major accomplishment!

Dr-Irv · 2025-09-26T19:53:48Z

@cmp0xff I have just released v2.3.2.250926 so we'll see what feedback we will get

cmp0xff commented Jul 12, 2025

View reviewed changes

cmp0xff marked this pull request as ready for review July 12, 2025 21:49

loicdiridollou reviewed Jul 12, 2025

View reviewed changes

pandas-stubs/core/tools/datetimes.pyi Show resolved Hide resolved

cmp0xff commented Jul 13, 2025

View reviewed changes

twoertwein reviewed Jul 13, 2025

View reviewed changes

cmp0xff added a commit to cmp0xff/pandas-stubs that referenced this pull request Jul 13, 2025

fix(comment): pandas-dev#718 only drop TimestampSeries pandas-dev#127…

1b270b1

…3 (review)

cmp0xff force-pushed the hotfix/cmp0xff/gh718-drop-tss-tds branch from 5916fe1 to 3a27b71 Compare July 13, 2025 06:59

cmp0xff marked this pull request as draft July 13, 2025 07:01

cmp0xff changed the title ~~fix: #718 drop TimestampSeries and TimedeltaSeries~~ fix: #718 also drop TimedeltaSeries Jul 13, 2025

cmp0xff changed the title ~~fix: #718 also drop TimedeltaSeries~~ refactor: #718 also drop TimedeltaSeries Jul 13, 2025

cmp0xff mentioned this pull request Jul 13, 2025

refactor(series)!: 🕰️ drop TimestampSeries #1274

Merged

4 tasks

cmp0xff force-pushed the hotfix/cmp0xff/gh718-drop-tss-tds branch from 3a27b71 to dfd0dc5 Compare July 13, 2025 10:48

cmp0xff mentioned this pull request Jul 13, 2025

feat(series): #1098 arithmetic addition #1275

Merged

2 tasks

cmp0xff added a commit to cmp0xff/pandas-stubs that referenced this pull request Jul 16, 2025

fix(comment): pandas-dev#718 only drop TimestampSeries pandas-dev#127…

d5e1089

…3 (review)

cmp0xff added a commit to cmp0xff/pandas-stubs that referenced this pull request Jul 16, 2025

fix(comment): pandas-dev#718 only drop TimestampSeries pandas-dev#127…

41c7015

…3 (review)

cmp0xff force-pushed the hotfix/cmp0xff/gh718-drop-tss-tds branch 2 times, most recently from 6caa0c8 to 333eed7 Compare July 17, 2025 09:13

cmp0xff added 2 commits July 17, 2025 17:09

refactor: only drop TimestampSeries pandas-dev#1273 (review)

cbbd372

refactor: also remove TimedeltaSeries

3df8ea0

cmp0xff force-pushed the hotfix/cmp0xff/gh718-drop-tss-tds branch from 333eed7 to 3df8ea0 Compare July 17, 2025 15:10

cmp0xff added a commit to cmp0xff/pandas-stubs that referenced this pull request Jul 28, 2025

refactor: only drop TimestampSeries pandas-dev#1273 (review)

8a99cf4

Merge branch 'main' into hotfix/cmp0xff/gh718-drop-tss-tds

89dd2f2

cmp0xff force-pushed the hotfix/cmp0xff/gh718-drop-tss-tds branch from dbe65e4 to 89dd2f2 Compare September 21, 2025 17:18

cmp0xff added 4 commits September 22, 2025 17:13

Merge branch 'main' into hotfix/cmp0xff/gh718-drop-tss-tds

48df895

feat: add

48a72c3

feat(test): sub

61b83ce

feat(test): mul

09aeaf7

cmp0xff added 2 commits September 24, 2025 21:23

feat(test): truediv

a916a31

feat(test): floordiv

9d364be

cmp0xff changed the title ~~refactor: #718 also drop TimedeltaSeries~~ refactor(series)!: ⏱️ drop TimedeltaSeries Sep 24, 2025

feat(test): remove redundant

9e840fc

cmp0xff marked this pull request as ready for review September 24, 2025 20:13

fix: pandas-dev/pandas#62316

27e81a0

Dr-Irv requested changes Sep 25, 2025

View reviewed changes

cmp0xff mentioned this pull request Sep 25, 2025

Create tests for arithmetic for TimedeltaIndex and DatetimeIndex #1378

Open

cmp0xff added 2 commits September 25, 2025 20:05

fix: comments

05fad40

fix(test): ignore mypy for now

bad9882

cmp0xff requested a review from Dr-Irv September 25, 2025 18:35

Dr-Irv reviewed Sep 25, 2025

View reviewed changes

tests/series/test_agg.py Show resolved Hide resolved

ttest.py Outdated Show resolved Hide resolved

pandas-stubs/core/series.pyi Show resolved Hide resolved

fix: comments

ddc41d1

cmp0xff requested a review from Dr-Irv September 26, 2025 09:04

Dr-Irv requested changes Sep 26, 2025

View reviewed changes

fix: comments

f094cd7

cmp0xff requested a review from Dr-Irv September 26, 2025 18:06

Dr-Irv approved these changes Sep 26, 2025

View reviewed changes

Dr-Irv merged commit 7ac98f2 into pandas-dev:main Sep 26, 2025
13 checks passed

Dr-Irv mentioned this pull request Sep 26, 2025

CLEAN: Investigate whether TimestampSeries, TimedeltaSeries, etc. can be removed #718

Closed

cmp0xff deleted the hotfix/cmp0xff/gh718-drop-tss-tds branch September 26, 2025 20:02

Uh oh!

refactor(series)!: ⏱️ drop TimedeltaSeries #1273

refactor(series)!: ⏱️ drop TimedeltaSeries #1273

Uh oh!

Conversation

cmp0xff commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loicdiridollou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

twoertwein left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmp0xff commented Jul 13, 2025

Uh oh!

Dr-Irv commented Jul 24, 2025

Uh oh!

cmp0xff commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr-Irv commented Sep 24, 2025

Uh oh!

Dr-Irv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dr-Irv Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

cmp0xff Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Dr-Irv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dr-Irv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dr-Irv left a comment

Choose a reason for hiding this comment

Uh oh!

cmp0xff commented Jul 12, 2025 •

edited

Loading

cmp0xff commented Sep 24, 2025 •

edited

Loading