initial pass at adding tags #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
davepacheco
approved these changes
Jan 11, 2022
ahl
commented
Jan 11, 2022
nexus/tests/output/nexus_tags.txt
Outdated
| @@ -0,0 +1,81 @@ | |||
| hardware | |||
There was a problem hiding this comment.
@davepacheco like this:
Suggested change
| hardware | |
| operations for tag "hardware" |
There was a problem hiding this comment.
That is what I meant. Even more explicit though:
Suggested change
| hardware | |
| API operations found with tag "hardware" | |
| OPERATION NAME URL PATH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #535
This adds tags and a mechanism to verify that there's exactly one per endpoint. This also creates a file of tags and endpoints to help people see how endpoints are organized when adding new ones.
@jessfraz I picked not very good names for the tags; if you have opinions about better names, let me know.
If we want the
tagsproperty of theopenapiheader to be populated with a list of these, we can make that change in Dropshot, but it's not required by the spec so we didn't bother.