change Into -> From in nexus external API views file

Author: david-crespo

nexus/src/external_api/views.rs

@@ -26,9 +26,9 @@ pub struct Organization {
     pub identity: IdentityMetadata,
 }
 
-impl Into<Organization> for model::Organization {
-    fn into(self) -> Organization {
-        Organization { identity: self.identity() }
+impl From<model::Organization> for Organization {
+    fn from(o: model::Organization) -> Self {
+        Self { identity: o.identity() }
     }
 }
 
@@ -44,12 +44,9 @@ pub struct Project {
     pub organization_id: Uuid,
 }
 
-impl Into<Project> for model::Project {
-    fn into(self) -> Project {
-        Project {
-            identity: self.identity(),
-            organization_id: self.organization_id,
-        }
+impl From<model::Project> for Project {
+    fn from(p: model::Project) -> Self {
+        Self { identity: p.identity(), organization_id: p.organization_id }
     }
 }
 
@@ -88,14 +85,14 @@ pub struct Vpc {
     pub dns_name: Name,
 }
 
-impl Into<Vpc> for model::Vpc {
-    fn into(self) -> Vpc {
-        Vpc {
-            identity: self.identity(),
-            project_id: self.project_id,
-            system_router_id: self.system_router_id,
-            ipv6_prefix: *self.ipv6_prefix,
-            dns_name: self.dns_name.0,
+impl From<model::Vpc> for Vpc {
+    fn from(v: model::Vpc) -> Self {
+        Self {
+            identity: v.identity(),
+            project_id: v.project_id,
+            system_router_id: v.system_router_id,
+            ipv6_prefix: *v.ipv6_prefix,
+            dns_name: v.dns_name.0,
         }
     }
 }
@@ -118,13 +115,13 @@ pub struct VpcSubnet {
     pub ipv6_block: Ipv6Net,
 }
 
-impl Into<VpcSubnet> for model::VpcSubnet {
-    fn into(self) -> VpcSubnet {
-        VpcSubnet {
-            identity: self.identity(),
-            vpc_id: self.vpc_id,
-            ipv4_block: self.ipv4_block.0,
-            ipv6_block: self.ipv6_block.0,
+impl From<model::VpcSubnet> for VpcSubnet {
+    fn from(s: model::VpcSubnet) -> Self {
+        Self {
+            identity: s.identity(),
+            vpc_id: s.vpc_id,
+            ipv4_block: s.ipv4_block.0,
+            ipv6_block: s.ipv6_block.0,
         }
     }
 }
@@ -174,9 +171,9 @@ pub struct Rack {
     pub identity: IdentityMetadata,
 }
 
-impl Into<Rack> for model::Rack {
-    fn into(self) -> Rack {
-        Rack { identity: self.identity() }
+impl From<model::Rack> for Rack {
+    fn from(r: model::Rack) -> Self {
+        Self { identity: r.identity() }
     }
 }
 
@@ -190,9 +187,9 @@ pub struct Sled {
     pub service_address: SocketAddr,
 }
 
-impl Into<Sled> for model::Sled {
-    fn into(self) -> Sled {
-        Sled { identity: self.identity(), service_address: self.address() }
+impl From<model::Sled> for Sled {
+    fn from(s: model::Sled) -> Self {
+        Self { identity: s.identity(), service_address: s.address() }
     }
 }
 
@@ -207,9 +204,9 @@ pub struct User {
     pub identity: IdentityMetadata,
 }
 
-impl Into<User> for model::UserBuiltin {
-    fn into(self) -> User {
-        User { identity: self.identity() }
+impl From<model::UserBuiltin> for User {
+    fn from(u: model::UserBuiltin) -> Self {
+        Self { identity: u.identity() }
     }
 }
 
@@ -221,9 +218,9 @@ pub struct SessionUser {
     pub id: Uuid,
 }
 
-impl Into<SessionUser> for authn::Actor {
-    fn into(self) -> SessionUser {
-        SessionUser { id: self.0 }
+impl From<authn::Actor> for SessionUser {
+    fn from(a: authn::Actor) -> Self {
+        Self { id: a.0 }
     }
 }
 
@@ -236,11 +233,11 @@ pub struct Role {
     pub description: String,
 }
 
-impl Into<Role> for model::RoleBuiltin {
-    fn into(self) -> Role {
-        Role {
-            name: RoleName::new(&self.resource_type, &self.role_name),
-            description: self.description,
+impl From<model::RoleBuiltin> for Role {
+    fn from(r: model::RoleBuiltin) -> Self {
+        Self {
+            name: RoleName::new(&r.resource_type, &r.role_name),
+            description: r.description,
         }
     }
 }