make silo base route private, make IdPs route canonical

Author: david-crespo

app/util/__snapshots__/path-builder.spec.ts.snap

@@ -537,7 +537,7 @@ exports[`breadcrumbs 2`] = `
       "path": "/projects/p/instances/i/serial-console",
     },
   ],
-  "silo (/system/silos/s)": [
+  "silo (/system/silos/s/idps)": [
     {
       "label": "Silos",
       "path": "/system/silos",

app/util/path-builder.spec.ts

@@ -79,7 +79,7 @@ test('path builder', () => {
         "projectsNew": "/projects-new",
         "samlIdp": "/system/silos/s/idps/saml/pr",
         "serialConsole": "/projects/p/instances/i/serial-console",
-        "silo": "/system/silos/s",
+        "silo": "/system/silos/s/idps",
         "siloAccess": "/access",
         "siloFleetRoles": "/system/silos/s/fleet-roles",
         "siloIdps": "/system/silos/s/idps",

app/util/path-builder.ts

@@ -18,6 +18,7 @@ const vpcBase = ({ project, vpc }: PP.Vpc) => `${pb.vpcs({ project })}/${vpc}`
 export const instanceMetricsBase = ({ project, instance }: PP.Instance) =>
   `${instanceBase({ project, instance })}/metrics`
 export const inventoryBase = () => '/system/inventory'
+const siloBase = ({ silo }: PP.Silo) => `/system/silos/${silo}`
 
 export const pb = {
   projects: () => `/projects`,
@@ -122,14 +123,15 @@ export const pb = {
 
   silos: () => '/system/silos',
   silosNew: () => '/system/silos-new',
-  silo: ({ silo }: PP.Silo) => `/system/silos/${silo}`,
-  siloIdps: (params: PP.Silo) => `${pb.silo(params)}/idps`,
-  siloIdpsNew: (params: PP.Silo) => `${pb.silo(params)}/idps-new`,
-  siloIpPools: (params: PP.Silo) => `${pb.silo(params)}/ip-pools`,
-  siloQuotas: (params: PP.Silo) => `${pb.silo(params)}/quotas`,
-  siloFleetRoles: (params: PP.Silo) => `${pb.silo(params)}/fleet-roles`,
+  // canonical route for silo is first tab
+  silo: (params: PP.Silo) => pb.siloIdps(params),
+  siloIdps: (params: PP.Silo) => `${siloBase(params)}/idps`,
+  siloIdpsNew: (params: PP.Silo) => `${siloBase(params)}/idps-new`,
+  siloIpPools: (params: PP.Silo) => `${siloBase(params)}/ip-pools`,
+  siloQuotas: (params: PP.Silo) => `${siloBase(params)}/quotas`,
+  siloFleetRoles: (params: PP.Silo) => `${siloBase(params)}/fleet-roles`,
   samlIdp: (params: PP.IdentityProvider) =>
-    `${pb.silo(params)}/idps/saml/${params.provider}`,
+    `${siloBase(params)}/idps/saml/${params.provider}`,
 
   profile: () => '/settings/profile',
   sshKeys: () => '/settings/ssh-keys',