refactor(EvaluatorCommand): Avoid storing URLs in sets

`URL`'s `equals()` and `hashCode()` methods can perform a DNS lookup to
resolve the host name, which may cause significant delays. So avoid
using `URL` instances in sets by using `URI` instances instead.

Also see 17e7327.

Signed-off-by: Sebastian Schuberth <[email protected]>

Author: sschuberth

plugins/commands/evaluator/src/main/kotlin/EvaluatorCommand.kt

@@ -32,7 +32,7 @@ import com.github.ajalt.clikt.parameters.types.enum
 import com.github.ajalt.clikt.parameters.types.file
 
 import java.io.File
-import java.net.URL
+import java.net.URI
 import java.time.Duration
 
 import kotlin.time.toKotlinDuration
@@ -198,13 +198,13 @@ class EvaluatorCommand : OrtCommand(
     ).flag()
 
     override fun run() {
-        val scriptUrls = mutableSetOf<URL>()
+        val scriptUrls = mutableSetOf<URI>()
 
-        rulesFile.mapTo(scriptUrls) { it.toURI().toURL() }
-        rulesResource.mapTo(scriptUrls) { javaClass.getResource(it) }
+        rulesFile.mapTo(scriptUrls) { it.toURI() }
+        rulesResource.mapTo(scriptUrls) { javaClass.getResource(it).toURI() }
 
         if (scriptUrls.isEmpty()) {
-            scriptUrls += ortConfigDirectory.resolve(ORT_EVALUATOR_RULES_FILENAME).toURI().toURL()
+            scriptUrls += ortConfigDirectory.resolve(ORT_EVALUATOR_RULES_FILENAME).toURI()
         }
 
         val configurationFiles = listOfNotNull(
@@ -238,7 +238,7 @@ class EvaluatorCommand : OrtCommand(
             var allChecksSucceeded = true
 
             scriptUrls.forEach {
-                if (evaluator.checkSyntax(it.readText())) {
+                if (evaluator.checkSyntax(it.toURL().readText())) {
                     println("Syntax check for $it succeeded.")
                 } else {
                     println("Syntax check for $it failed.")
@@ -312,7 +312,7 @@ class EvaluatorCommand : OrtCommand(
             licenseClassificationsFile.takeIf { it.isFile }?.readValue<LicenseClassifications>().orEmpty()
         val evaluator = Evaluator(ortResultInput, licenseInfoResolver, resolutionProvider, licenseClassifications)
 
-        val scripts = scriptUrls.map { it.readText() }
+        val scripts = scriptUrls.map { it.toURL().readText() }
         val evaluatorRun = evaluator.run(*scripts.toTypedArray())
 
         val duration = with(evaluatorRun) { Duration.between(startTime, endTime).toKotlinDuration() }