Skip to content

Explicitly export exception types. #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

oraluben
Copy link
Contributor

@oraluben oraluben commented Jun 1, 2021

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #332 (81d16d9) into master (b263ba5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files         282      282           
  Lines       20712    20712           
=======================================
  Hits        16416    16416           
  Misses       4296     4296           
Flag Coverage Δ
data_tests 56.50% <ø> (ø)
examples 51.57% <ø> (ø)
unit_tests 75.13% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/osmium/geom/factory.hpp 97.45% <ø> (ø)
include/osmium/geom/util.hpp 100.00% <ø> (ø)
include/osmium/handler/check_order.hpp 93.75% <ø> (ø)
include/osmium/index/index.hpp 50.00% <ø> (ø)
include/osmium/index/map.hpp 86.84% <ø> (ø)
include/osmium/io/error.hpp 100.00% <ø> (ø)
include/osmium/memory/buffer.hpp 74.27% <ø> (ø)
include/osmium/osm/item_type.hpp 26.53% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b263ba5...81d16d9. Read the comment docs.

@oraluben
Copy link
Contributor Author

oraluben commented Jun 1, 2021

Working on CI failure.

I'm not able to reproduce the CI failures, would someone have any hint about what happened?

@joto
Copy link
Member

joto commented Jun 6, 2021

Looks to me like you probably didn't include the compatibility.hpp everywhere that's needed. For instance in include/osmium/memory/buffer.hpp.

@oraluben
Copy link
Contributor Author

oraluben commented Jun 6, 2021

Looks to me like you probably didn't include the compatibility.hpp everywhere that's needed. For instance in include/osmium/memory/buffer.hpp.

Thanks for your reply! They already included the file (e.g. in buffer.hpp), and I also successfully compiled the project. Is there anything different I should notice between local and the CI's environment?

joto added a commit to joto/gdalcpp that referenced this pull request Sep 25, 2021
@joto
Copy link
Member

joto commented Sep 25, 2021

I have merged this now (in slightly different form). Sorry it took so long, but I needed to understand what's happening here first.

@joto joto closed this Sep 25, 2021
@joto
Copy link
Member

joto commented Sep 27, 2021

Because VS is generating warnings I wrapped the code defining OSMIUM_EXPORT into an #ifdef OSMIUM_DEFINE_EXPORT. So you have to compile with -DOSMIUM_DEFINE_EXPORT if you need this functionality. Can you provide a PR for Pyosmium if that works for you?

@oraluben
Copy link
Contributor Author

@joto thanks! I'll try to draft a PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Test failure when build with libc++
3 participants