-
-
Notifications
You must be signed in to change notification settings - Fork 118
Explicitly export exception types. #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 79.25% 79.25%
=======================================
Files 282 282
Lines 20712 20712
=======================================
Hits 16416 16416
Misses 4296 4296
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I'm not able to reproduce the CI failures, would someone have any hint about what happened? |
Looks to me like you probably didn't include the |
Thanks for your reply! They already included the file (e.g. in |
I have merged this now (in slightly different form). Sorry it took so long, but I needed to understand what's happening here first. |
Because VS is generating warnings I wrapped the code defining |
@joto thanks! I'll try to draft a PR there. |
This should fix osmcode/pyosmium#165
Ref: pybind/pybind11#2999, GCC Wiki