Disable some clang-tidy warnings for empty catch

Author: joto

include/osmium/io/detail/read_thread.hpp

@@ -106,7 +106,7 @@ namespace osmium {
                 ~ReadThreadManager() noexcept {
                     try {
                         close();
-                    } catch (...) {
+                    } catch (...) { // NOLINT(bugprone-empty-catch)
                         // Ignore any exceptions because destructor must not throw.
                     }
                 }

include/osmium/io/reader.hpp

@@ -390,7 +390,7 @@ namespace osmium {
 
                 try {
                     m_read_thread_manager.close();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Ignore any exceptions.
                 }
 

include/osmium/util/progress_bar.hpp

@@ -132,7 +132,7 @@ namespace osmium {
             if (m_do_cleanup) {
                 try {
                     done();
-                } catch (...) {
+                } catch (...) { // NOLINT(bugprone-empty-catch)
                     // Swallow any exceptions, because a destructor should
                     // not throw.
                 }

test/t/io/test_reader.cpp

@@ -266,7 +266,7 @@ TEST_CASE("Reader should work when there is an exception in main thread before g
         const osmium::io::Reader reader{with_data_dir("t/io/data.osm")};
         REQUIRE_FALSE(reader.eof());
         throw std::runtime_error{"foo"};
-    } catch (...) {
+    } catch (...) { // NOLINT(bugprone-empty-catch)
     }
 
     REQUIRE(count == count_fds());
@@ -280,7 +280,7 @@ TEST_CASE("Reader should work when there is an exception in main thread while re
         REQUIRE_FALSE(reader.eof());
         auto header = reader.header();
         throw std::runtime_error{"foo"};
-    } catch (...) {
+    } catch (...) { // NOLINT(bugprone-empty-catch)
     }
 
     REQUIRE(count == count_fds());