4565: Applied coding standards

Author: tuj

composer.json

@@ -131,14 +131,6 @@
         "fixtures-load": [
             "bin/console hautelook:fixtures:load --no-interaction"
         ],
-        "prepare-code": [
-            "bin/console doctrine:schema:validate",
-            "@coding-standards-apply",
-            "vendor/bin/rector",
-            "vendor/bin/psalm --no-cache",
-            "@test-setup",
-            "@test"
-        ],
         "test": [
             "vendor/bin/phpunit --stop-on-failure"
         ],

src/Command/UpdateCommand.php

@@ -19,12 +19,11 @@
 )]
 class UpdateCommand extends Command
 {
-    private TemplateService $templateService;
-
-    public function __construct(TemplateService $templateService, ?string $name = null)
-    {
+    public function __construct(
+        private readonly TemplateService $templateService,
+        ?string $name = null
+    ) {
         parent::__construct($name);
-        $this->templateService = $templateService;
     }
 
     final protected function execute(InputInterface $input, OutputInterface $output): int

src/Command/Utils/ConvertConfigJsonToEnvCommand.php

@@ -39,7 +39,7 @@ final protected function execute(InputInterface $input, OutputInterface $output)
         try {
             $content = file_get_contents($input->getArgument('filepath'));
 
-            if (!$content) {
+            if (false === $content) {
                 throw new \Exception('Error reading file');
             }
 
@@ -56,7 +56,6 @@ final protected function execute(InputInterface $input, OutputInterface $output)
             $rejseplanenApiKey = $config['rejseplanenApiKey'] ?? null;
             $showScreenStatus = $config['showScreenStatus'] ?? null;
             $touchButtonRegions = $config['touchButtonRegions'] ?? null;
-            $enhancedPreview = $config['previewClient'] ?? null;
             $loginMethods = $config['loginMethods'] ?? null;
 
             if (null !== $loginMethods) {
@@ -72,7 +71,7 @@ final protected function execute(InputInterface $input, OutputInterface $output)
             null !== $touchButtonRegions && $io->writeln('ADMIN_TOUCH_BUTTON_REGIONS='.var_export($touchButtonRegions, true));
             null !== $loginMethods && $io->writeln("ADMIN_LOGIN_METHODS='".json_encode($loginMethods)."'");
             // This is a conversion from an url to boolean value. If the url is not empty, it is interpreted as true.
-            !empty($enhancedPreview) && $io->writeln('ADMIN_ENHANCED_PREVIEW=true');
+            !empty($config['previewClient']) && $io->writeln('ADMIN_ENHANCED_PREVIEW=true');
             $io->writeln('###< Admin configuration ###');
         } elseif ('client' === $type) {
             $io->success('Insert the following lines in .env.local');