wip - config introduction

mironbalcerzak · mironbalcerzak · commit 45f4d4d045b4 · 2024-11-24T09:43:57.000+01:00
diff --git a/packages/core/src/generators/component-definition.ts b/packages/core/src/generators/component-definition.ts
@@ -55,6 +55,7 @@ export const generateComponentDefinition = (
       if (modelName !== type) {
         acc.push({
           name: modelName,
+          factoryMethod: '',
           model,
           imports,
         });
diff --git a/packages/core/src/generators/imports.ts b/packages/core/src/generators/imports.ts
@@ -5,6 +5,7 @@ import {
   GeneratorMutator,
   GeneratorVerbOptions,
   GetterPropType,
+  OutputModelFactoryMethodsMode,
 } from '../types';
 import { camel, upath } from '../utils';
 
@@ -14,12 +15,16 @@ export const generateImports = ({
   isRootKey,
   specsName,
   specKey: currentSpecKey,
+  factoryMethodOutput,
+  factoryMethodPrefix
 }: {
   imports: GeneratorImport[];
   target: string;
   isRootKey: boolean;
   specsName: Record<string, string>;
   specKey: string;
+  factoryMethodOutput?: (typeof OutputModelFactoryMethodsMode)[keyof typeof OutputModelFactoryMethodsMode];
+  factoryMethodPrefix?: string;
 }) => {
   if (!imports.length) {
     return '';
@@ -47,9 +52,14 @@ export const generateImports = ({
         } } from \'./${upath.join(path, camel(name))}\';`;
       }
 
-      return `import { create${name}, ${name}${
+      let mainImport = `import ${!values ? 'type ' : ''}{ ${name}${
         alias ? ` as ${alias}` : ''
-      } } from \'./${camel(name)}\';`;
+      }${factoryMethodOutput == OutputModelFactoryMethodsMode.SINGLE ? `${factoryMethodPrefix}${name}` : ''} } from \'./${camel(name)}\';`;
+      if (factoryMethodOutput == OutputModelFactoryMethodsMode.SPLIT) {
+        let factoryMethodImport = `import { ${factoryMethodPrefix}${name} } from \'./${camel(name)}.factory\';`;
+        mainImport += '\n' + factoryMethodImport;
+      }
+      return mainImport;
     })
     .join('\n');
 };
diff --git a/packages/core/src/generators/interface.ts b/packages/core/src/generators/interface.ts
@@ -1,6 +1,6 @@
 import { SchemaObject } from 'openapi3-ts/oas30';
 import { getScalar } from '../getters';
-import { ContextSpecs } from '../types';
+import { ContextSpecs, OutputModelFactoryMethodsMode } from '../types';
 import { jsDoc } from '../utils';
 
 /**
@@ -53,18 +53,27 @@ export const generateInterface = ({
   } else {
     model += `export type ${name} = ${scalar.value};\n`;
   }
-  model += `export function create${name}(): ${name} ${scalar.factoryMethodValue}\n`;
-
   // Filter out imports that refer to the type defined in current file (OpenAPI recursive schema definitions)
   const externalModulesImportsOnly = scalar.imports.filter(
     (importName) => importName.name !== name,
   );
 
+  let factoryMethod: string = '';
+  if (context?.output.modelFactoryMethods) {
+    let factoryMethodPrefix = context?.output.override?.modelFactoryMethods?.factoryMethodPrefix!;
+    factoryMethod = `export function ${factoryMethodPrefix}${name}(): ${name} ${scalar.factoryMethodValue}\n`;
+    if (context?.output.override?.modelFactoryMethods?.outputMode == OutputModelFactoryMethodsMode.SINGLE) {
+      model += factoryMethod;
+      factoryMethod = '';
+    }
+  }
+
   return [
     ...scalar.schemas,
     {
       name,
       model,
+      factoryMethod,
       imports: externalModulesImportsOnly,
     },
   ];
diff --git a/packages/core/src/generators/parameter-definition.ts b/packages/core/src/generators/parameter-definition.ts
@@ -29,6 +29,7 @@ export const generateParameterDefinition = (
       if (!schema.schema || imports.length) {
         acc.push({
           name: modelName,
+          factoryMethod: '',
           imports: imports.length
             ? [
                 {
@@ -63,6 +64,7 @@ export const generateParameterDefinition = (
       if (modelName !== resolvedObject.value) {
         acc.push({
           name: modelName,
+          factoryMethod: '',
           model,
           imports: resolvedObject.imports,
         });
diff --git a/packages/core/src/generators/schema-definition.ts b/packages/core/src/generators/schema-definition.ts
@@ -127,6 +127,7 @@ export const generateSchemasDefinition = (
 
       acc.push(...resolvedValue.schemas, {
         name: schemaName,
+        factoryMethod: '',
         model: output,
         imports,
       });
diff --git a/packages/core/src/getters/combine.ts b/packages/core/src/getters/combine.ts
@@ -193,6 +193,7 @@ export const combineSchemas = ({
             })),
           ],
           model: newEnum,
+          factoryMethod: '',
           name: name,
         },
       ],
diff --git a/packages/core/src/getters/props.ts b/packages/core/src/getters/props.ts
@@ -96,6 +96,7 @@ export const getProps = ({
         required: true,
         schema: {
           name: parameterTypeName,
+          factoryMethod: '',
           model: namedParametersTypeDefinition,
           imports: params.flatMap((property) => property.imports),
         },
diff --git a/packages/core/src/getters/query-params.ts b/packages/core/src/getters/query-params.ts
@@ -82,7 +82,7 @@ const getQueryParamsTypes = (
         imports: [{ name: enumName }],
         schemas: [
           ...resolvedValue.schemas,
-          { name: enumName, model: enumValue, imports: resolvedValue.imports },
+          { name: enumName, model: enumValue, factoryMethod: '', imports: resolvedValue.imports },
         ],
         originalSchema: resolvedValue.originalSchema,
       };
@@ -125,6 +125,7 @@ export const getQueryParams = ({
 
   const schema = {
     name,
+    factoryMethod: '',
     model: `export type ${name} = {\n${type}\n};\n`,
     imports,
   };
diff --git a/packages/core/src/resolvers/object.ts b/packages/core/src/resolvers/object.ts
@@ -36,6 +36,7 @@ const resolveObjectOriginal = ({
         ...resolvedValue.schemas,
         {
           name: propName,
+          factoryMethod: `export function ${context.output.override.modelFactoryMethods?.factoryMethodPrefix}${propName}(): ${propName}${resolvedValue.factoryMethodValue}`,
           model: `${doc}export type ${propName} = ${resolvedValue.value};\n`,
           imports: resolvedValue.imports,
         },
@@ -55,14 +56,19 @@ const resolveObjectOriginal = ({
       resolvedValue.originalSchema?.['x-enumNames'],
       context.output.override.useNativeEnums,
     );
+    const factoryMethodValue = context?.output.override?.useTypeOverInterfaces
+      ? `${propName}[${resolvedValue.value.split(' | ')[0]}]`
+      : `${resolvedValue.value.split(' | ')[0]}`;
+
 
     return {
       value: propName,
-      factoryMethodValue: `${propName}[${resolvedValue.value.split(' | ')[0]}]`,
+      factoryMethodValue,
       imports: [{ name: propName }],
       schemas: [
         ...resolvedValue.schemas,
         {
+          factoryMethod: '',
           name: propName,
           model: doc + enumValue,
           imports: resolvedValue.imports,
diff --git a/packages/core/src/resolvers/value.ts b/packages/core/src/resolvers/value.ts
@@ -44,7 +44,7 @@ export const resolveValue = ({
 
     return {
       value: resolvedImport.name,
-      factoryMethodValue: `create${resolvedImport.name}()`,
+      factoryMethodValue: `${context.output.override.modelFactoryMethods?.factoryMethodPrefix}${resolvedImport.name}()`,
       imports: [
         {
           name: resolvedImport.name,
diff --git a/packages/core/src/types.ts b/packages/core/src/types.ts
@@ -50,6 +50,7 @@ export type NormalizedOutputOptions = {
   override: NormalizedOverrideOutput;
   client: OutputClient | OutputClientFunc;
   httpClient: OutputHttpClient;
+  modelFactoryMethods?: boolean;
   clean: boolean | string[];
   docs: boolean | OutputDocsOptions;
   prettier: boolean;
@@ -70,6 +71,16 @@ export type NormalizedParamsSerializerOptions = {
   qs?: Record<string, any>;
 };
 
+export const OutputModelFactoryMethodsMode = {
+  SINGLE: 'single',
+  SPLIT: 'split',
+} as const;
+
+export type NormalizedModelFactoryMethodsOptions = {
+  factoryMethodPrefix?: string;
+  outputMode?: (typeof OutputModelFactoryMethodsMode)[keyof typeof OutputModelFactoryMethodsMode];
+};
+
 export type NormalizedOverrideOutput = {
   title?: (title: string) => string;
   transformer?: OutputTransformer;
@@ -83,6 +94,7 @@ export type NormalizedOverrideOutput = {
   formUrlEncoded: boolean | NormalizedMutator;
   paramsSerializer?: NormalizedMutator;
   paramsSerializerOptions?: NormalizedParamsSerializerOptions;
+  modelFactoryMethods?: NormalizedModelFactoryMethodsOptions;
   components: {
     schemas: {
       suffix: string;
@@ -175,6 +187,7 @@ export type OutputOptions = {
   override?: OverrideOutput;
   client?: OutputClient | OutputClientFunc;
   httpClient?: OutputHttpClient;
+  modelFactoryMethods?: boolean;
   clean?: boolean | string[];
   docs?: boolean | OutputDocsOptions;
   prettier?: boolean;
@@ -328,6 +341,11 @@ export type ParamsSerializerOptions = {
   qs?: Record<string, any>;
 };
 
+export type ModelFactoryMethodsOptions = {
+  factoryMethodPrefix?: string;
+  outputMode?: (typeof OutputModelFactoryMethodsMode)[keyof typeof OutputModelFactoryMethodsMode];
+};
+
 export type OverrideOutput = {
   title?: (title: string) => string;
   transformer?: OutputTransformer;
@@ -341,6 +359,7 @@ export type OverrideOutput = {
   formUrlEncoded?: boolean | Mutator;
   paramsSerializer?: Mutator;
   paramsSerializerOptions?: ParamsSerializerOptions;
+  modelFactoryMethods?: ModelFactoryMethodsOptions;
   components?: {
     schemas?: {
       suffix?: string;
@@ -603,6 +622,7 @@ export interface GlobalOptions {
   mock?: boolean | GlobalMockOptions;
   client?: OutputClient;
   httpClient?: OutputHttpClient;
+  modelFactoryMethods?: boolean;
   mode?: OutputMode;
   tsconfig?: string | Tsconfig;
   packageJson?: string;
@@ -644,6 +664,7 @@ export interface PackageJson {
 export type GeneratorSchema = {
   name: string;
   model: string;
+  factoryMethod: string;
   imports: GeneratorImport[];
 };
 
diff --git a/packages/core/src/writers/schemas.ts b/packages/core/src/writers/schemas.ts
@@ -1,6 +1,6 @@
 import fs from 'fs-extra';
 import { generateImports } from '../generators';
-import { GeneratorSchema } from '../types';
+import { GeneratorSchema, OutputModelFactoryMethodsMode } from '../types';
 import { camel, upath } from '../utils';
 
 const getSchema = ({
@@ -35,6 +35,46 @@ const getSchema = ({
   return file;
 };
 
+const getFactoryMethod = ({
+                     schema: { name, imports, model, factoryMethod },
+                     target,
+                     isRootKey,
+                     specsName,
+                     header,
+                     specKey,
+                     factoryMethodOutput,
+                     factoryMethodPrefix
+                   }: {
+  schema: GeneratorSchema;
+  target: string;
+  isRootKey: boolean;
+  specsName: Record<string, string>;
+  header: string;
+  specKey: string;
+  factoryMethodOutput?: (typeof OutputModelFactoryMethodsMode)[keyof typeof OutputModelFactoryMethodsMode];
+  factoryMethodPrefix?: string;
+}): string => {
+  let file = header;
+  file += generateImports({
+    imports: imports.filter(
+      (imp) =>
+        !model.includes(`type ${imp.alias || imp.name} =`) &&
+        !model.includes(`interface ${imp.alias || imp.name} {`),
+    ),
+    target,
+    isRootKey,
+    specsName,
+    specKey,
+    factoryMethodOutput,
+    factoryMethodPrefix
+  });
+  file += `import { ${name}} from \'./${camel(name)}\';`;
+  file += '\n\n';
+
+  file += factoryMethod;
+  return file;
+};
+
 const getPath = (path: string, name: string, fileExtension: string): string =>
   upath.join(path, `/${name}${fileExtension}`);
 
@@ -53,6 +93,9 @@ export const writeSchema = async ({
   isRootKey,
   specsName,
   header,
+  factoryMethodInclude,
+  factoryMethodOutput,
+  factoryMethodPrefix
 }: {
   path: string;
   schema: GeneratorSchema;
@@ -62,6 +105,10 @@ export const writeSchema = async ({
   isRootKey: boolean;
   specsName: Record<string, string>;
   header: string;
+  factoryMethodInclude: boolean;
+  factoryMethodOutput?: (typeof OutputModelFactoryMethodsMode)[keyof typeof OutputModelFactoryMethodsMode];
+  factoryMethodPrefix?: string;
+
 }) => {
   const name = camel(schema.name);
 
@@ -70,6 +117,12 @@ export const writeSchema = async ({
       getPath(path, name, fileExtension),
       getSchema({ schema, target, isRootKey, specsName, header, specKey }),
     );
+    if (factoryMethodInclude && schema.factoryMethod.length > 0) {
+      await fs.outputFile(
+        getPath(path, name + '.factory', fileExtension),
+        getFactoryMethod({ schema, target, isRootKey, specsName, header, specKey, factoryMethodOutput, factoryMethodPrefix }),
+      );
+    }
   } catch (e) {
     throw `Oups... 🍻. An Error occurred while writing schema ${name} => ${e}`;
   }
@@ -85,6 +138,9 @@ export const writeSchemas = async ({
   specsName,
   header,
   indexFiles,
+  factoryMethodInclude,
+  factoryMethodOutput,
+  factoryMethodPrefix
 }: {
   schemaPath: string;
   schemas: GeneratorSchema[];
@@ -95,6 +151,9 @@ export const writeSchemas = async ({
   specsName: Record<string, string>;
   header: string;
   indexFiles: boolean;
+  factoryMethodInclude: boolean;
+  factoryMethodOutput?: (typeof OutputModelFactoryMethodsMode)[keyof typeof OutputModelFactoryMethodsMode];
+  factoryMethodPrefix?: string;
 }) => {
   await Promise.all(
     schemas.map((schema) =>
@@ -107,6 +166,9 @@ export const writeSchemas = async ({
         isRootKey,
         specsName,
         header,
+        factoryMethodInclude,
+        factoryMethodOutput,
+        factoryMethodPrefix
       }),
     ),
   );
diff --git a/packages/orval/src/utils/options.ts b/packages/orval/src/utils/options.ts
diff --git a/packages/orval/src/write-specs.ts b/packages/orval/src/write-specs.ts

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export const resolveValue = ({`
`44`	`44`
`45`	`45`	`return {`
`46`	`46`	`value: resolvedImport.name,`
`47`		- factoryMethodValue: `create${resolvedImport.name}()`,
	`47`	+ factoryMethodValue: `${context.output.override.modelFactoryMethods?.factoryMethodPrefix}${resolvedImport.name}()`,
`48`	`48`	`imports: [`
`49`	`49`	`{`
`50`	`50`	`name: resolvedImport.name,`