refactor: replace unreachable project links heuristic with source code repo heuristic #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
art1f1c3R
force-pushed
the
art1f1c3R/pypi-proj-links-refactor
branch
from
ed2a934 to
57aba12
Compare
art1f1c3R
force-pushed
the
art1f1c3R/pypi-proj-links-refactor
branch
from
57aba12 to
2c5d787
Compare
behnazh-w
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the
UnreachableProjectLinksheuristic analyzer with a new heuristic analyzer,SourceCodeRepo. This replacement heuristic, instead of checking if all project links are reachable, checks if a source code repository is available. To do this, it relies on the previous processing to find and verify the package repository link, checking if thepypi_package_json.component.repositoryfield is present.TODO
Currently, the
SourceCodeRepoheuristic still has a dependency on theEmptyProjectLinksheuristic. This is done currently to make the merging process easier, and to avoid a heavy rework of theSUSPICIOUS_COMBOSdictionary. This dictionary is expected to soon be replaced with a more usable alternative, at which time the combinations including this heuristic may be updated.