Skip to content

docs: make minor formatting fixes #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

benmss
Copy link
Member

@benmss benmss commented Jun 4, 2025

Summary

This PR fixes various formatting issues in comments throughout the code base.

@benmss benmss self-assigned this Jun 4, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 4, 2025
@benmss benmss force-pushed the benmss/small-fixes-semgrep branch from ffaa219 to 66981ec Compare June 4, 2025 06:23
@benmss benmss assigned art1f1c3R and unassigned benmss Jun 4, 2025
@art1f1c3R
Copy link
Member

The changes in this PR seem fine to me, but I would like to try get an idea of how to reproduce the problem and how the rule ID path caused errors in the unit tests?

@benmss benmss force-pushed the benmss/small-fixes-semgrep branch from 66981ec to cbbecde Compare June 19, 2025 04:13
@benmss benmss assigned benmss and unassigned art1f1c3R Jun 19, 2025
benmss added 2 commits June 19, 2025 14:15
Signed-off-by: Ben Selwyn-Smith <[email protected]>
@benmss benmss force-pushed the benmss/small-fixes-semgrep branch from cbbecde to 2ae183b Compare June 19, 2025 04:22
@benmss benmss changed the title chore: semgrep test fixes and minor formatting fixes chore: minor formatting fixes Jun 20, 2025
@benmss
Copy link
Member Author

benmss commented Jun 20, 2025

The changes in this PR seem fine to me, but I would like to try get an idea of how to reproduce the problem and how the rule ID path caused errors in the unit tests?

This comment relates to the semgrep fix that was previously included in this PR. Further investigation led to removal of this "fix".

@benmss benmss marked this pull request as ready for review June 20, 2025 00:32
@benmss benmss requested review from behnazh-w and tromai as code owners June 20, 2025 00:32
@behnazh-w
Copy link
Member

behnazh-w commented Jun 20, 2025

@benmss Thanks for the PR. Can you please adjust the PR title to reflect the changes. I think docs would be a more suitable scope.

@benmss benmss changed the title chore: minor formatting fixes docs: minor formatting fixes Jun 20, 2025
@behnazh-w behnazh-w changed the title docs: minor formatting fixes docs: make minor formatting fixes Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants