-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Pre-built Database extension #2188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: abhisbyk <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
…on dockerfile Signed-off-by: abhisbyk <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick comments from reading some of the text. This is not a review of the feature or how it is coded.
OracleDatabase/SingleInstance/helm-charts/oracle-db/values.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: abhisbyk <[email protected]>
|
||
## Advantages | ||
|
||
This extended image has an additional layer containing pre-created database on top of the base image. So, when this image is used to spin-up a container, the startup time is really fast. In other words, this extended image saves the database creation time (~ 10-20 mins). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the grammar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence seems fine to me. Please elaborate what should be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an "a" missing before "pre-created"; however, I think we can probably rephrase that to make it easier to understand for the novice Docker user who doesn't know of image layers, etc.
How about: "This extended image includes an already setup database inside the image itself. Although the image size is larger, the startup time of the container includes only the database startup itself, which makes the container startup duration just a couple of seconds."
Would this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, the rephrased sentence has more clarity. Changed accordingly in the README.
@@ -27,6 +27,7 @@ enable_archivelog: false | |||
## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/ | |||
persistence: | |||
## Oracle database data Persistent Volume Storage Class, nfs or block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Database has a capital D in its name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
OracleDatabase/SingleInstance/helm-charts/oracle-db/values.yaml
Outdated
Show resolved
Hide resolved
… storageClass Signed-off-by: abhisbyk <[email protected]>
Correction in the command for building the prebuiltdb extension Co-authored-by: Sankar Periyathambi Neelakandan <[email protected]>
Signed-off-by: abhisbyk <[email protected]>
c35679a
to
89dec30
Compare
Support for extending the base image with pre-built database for CI/CD scenarios. Supports Oracle Database 19c onwards.