add support for Boolean Data type for server version above 23

Author: jawad-arb123

oracle/common.go

@@ -71,7 +71,7 @@ func getOracleArrayType(values []any) string {
 		}
 		switch v := val.(type) {
 		case bool:
-			arrayType = "TABLE OF NUMBER(1)"
+			arrayType = "TABLE OF BOOLEAN"
 		case int, int8, int16, int32, int64, uint, uint8, uint16, uint32, uint64, float32, float64:
 			arrayType = "TABLE OF NUMBER"
 		case time.Time:
@@ -132,7 +132,7 @@ func createTypedDestination(f *schema.Field) interface{} {
 
 	// To differentiate between bool fields stored as NUMBER(1) and bool fields stored as actual BOOLEAN type,
 	// check the struct's "type" tag.
-	if f.DataType == "boolean" {
+	if string(f.DataType) == "bool" || string(f.DataType) == "boolean" {
 		return new(bool)
 	}
 
@@ -199,7 +199,7 @@ func createTypedDestination(f *schema.Field) interface{} {
 		return new(string)
 
 	case reflect.Bool:
-		return new(int64)
+		return new(bool)
 
 	case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
 		return new(int64)
@@ -470,6 +470,9 @@ func isRawMessageField(f *schema.Field) bool {
 func convertPrimitiveType(value interface{}, targetType reflect.Type) interface{} {
 	switch targetType.Kind() {
 	case reflect.Bool:
+		if v, ok := value.(bool); ok {
+			return v
+		}
 		if v, ok := value.(int64); ok {
 			return v != 0
 		}

oracle/migrator.go

@@ -642,6 +642,7 @@ func (m Migrator) FullDataTypeOf(field *schema.Field) (expr clause.Expr) {
 // Builds Oracle-compatible default values from string
 func (m Migrator) buildOracleDefault(defaultValue string) string {
 	defaultValue = strings.TrimSpace(defaultValue)
+	dialector := m.Dialector.(Dialector)
 
 	if defaultValue == "" {
 		return ""
@@ -656,8 +657,14 @@ func (m Migrator) buildOracleDefault(defaultValue string) string {
 	case "SYSDATE":
 		return "DEFAULT SYSDATE"
 	case "TRUE":
+		if dialector.Config.ServerVersion >= 23 {
+			return "DEFAULT TRUE"
+		}
 		return "DEFAULT 1"
 	case "FALSE":
+		if dialector.Config.ServerVersion >= 23 {
+			return "DEFAULT FALSE"
+		}
 		return "DEFAULT 0"
 	}
 
@@ -689,8 +696,15 @@ func (m Migrator) buildOracleDefault(defaultValue string) string {
 
 // Build Oracle-compatible default values from Go interface
 func (m Migrator) buildOracleDefaultFromInterface(value interface{}) string {
+	dialector := m.Dialector.(Dialector)
 	switch v := value.(type) {
 	case bool:
+		if dialector.Config.ServerVersion >= 23 {
+			if v {
+				return "DEFAULT TRUE"
+			}
+			return "DEFAULT FALSE"
+		}
 		if v {
 			return "DEFAULT 1"
 		}

oracle/oracle.go

@@ -67,6 +67,7 @@ type Config struct {
 	Conn                 *sql.DB
 	DefaultStringSize    uint
 	SkipQuoteIdentifiers bool
+	ServerVersion        int
 }
 
 type Dialector struct {
@@ -132,6 +133,11 @@ func (d Dialector) Initialize(db *gorm.DB) (err error) {
 	if err != nil {
 		return err
 	}
+	version, err := GetServerVersion(db)
+	if err != nil {
+		return err
+	}
+	d.Config.ServerVersion = version
 
 	return nil
 }
@@ -188,7 +194,9 @@ func (d Dialector) getStringType(field *schema.Field) string {
 }
 
 func (d Dialector) getBooleanType() string {
-	// Oracle doesn't support BOOLEAN in CREATE TABLE, use NUMBER(1) instead
+	if d.Config.ServerVersion >= 23 {
+		return "BOOLEAN"
+	}
 	return "NUMBER(1)"
 }
 
@@ -294,3 +302,40 @@ func (d Dialector) RollbackTo(tx *gorm.DB, name string) error {
 	tx.Exec("ROLLBACK TO SAVEPOINT " + name)
 	return tx.Error
 }
+
+// GetServerVersion retrieves the Oracle server version as an integer.
+func GetServerVersion(db *gorm.DB) (int, error) {
+	sqlDB, err := db.DB()
+	if err != nil {
+		return 0, err
+	}
+	rows, err := sqlDB.Query("SELECT banner FROM v$version")
+	if err != nil {
+		return 0, err
+	}
+	defer rows.Close()
+	for rows.Next() {
+		var banner string
+		err = rows.Scan(&banner)
+		if err != nil {
+			return 0, err
+		}
+		// Parse banner
+		if strings.Contains(banner, "Oracle") && strings.Contains(banner, "Release") {
+			parts := strings.Split(banner, " ")
+			for i, p := range parts {
+				if p == "Release" && i+1 < len(parts) {
+					rel := parts[i+1]
+					dotPos := strings.Index(rel, ".")
+					if dotPos != -1 {
+						version, perr := strconv.Atoi(rel[:dotPos])
+						if perr == nil {
+							return version, nil
+						}
+					}
+				}
+			}
+		}
+	}
+	return 0, fmt.Errorf("could not find version in banners")
+}

tests/boolean_test.go

@@ -142,15 +142,30 @@ func TestBooleanNegativeInvalidDBValue(t *testing.T) {
 		t.Fatalf("failed to insert invalid bool: %v", err)
 	}
 
+	// Check if using native BOOLEAN or NUMBER(1)
+	var columnType string
+	DB.Raw(`SELECT DATA_TYPE FROM USER_TAB_COLUMNS 
+            WHERE TABLE_NAME = 'BOOLEAN_TESTS' AND COLUMN_NAME = 'FLAG'`).Scan(&columnType)
 	var got BooleanTest
 	err := DB.First(&got, 2001).Error
-	if err == nil {
-		t.Fatal("expected invalid boolean scan error, got nil")
-	}
-
-	if !strings.Contains(err.Error(), "invalid") &&
-		!strings.Contains(err.Error(), "convert") {
-		t.Fatalf("expected boolean conversion error, got: %v", err)
+	if columnType == "BOOLEAN" {
+		// Oracle database version above 23 native BOOLEAN accepts any number
+		if err != nil {
+			t.Fatalf("Oracle database version above 23 BOOLEAN should accept numeric value 2, got error: %v", err)
+		}
+		// Verify that 2 was treated as TRUE
+		if !got.Flag {
+			t.Errorf("expected FLAG=true for value 2 in BOOLEAN column, got false")
+		}
+	} else {
+		// Oracle database version below 23 uses NUMBER(1), should reject value 2
+		if err == nil {
+			t.Fatal("expected invalid boolean scan error, got nil")
+		}
+		if !strings.Contains(err.Error(), "invalid") &&
+			!strings.Contains(err.Error(), "convert") {
+			t.Fatalf("expected boolean conversion error, got: %v", err)
+		}
 	}
 }
 
@@ -229,9 +244,24 @@ func TestBooleanQueryMixedComparisons(t *testing.T) {
 		t.Errorf("expected at least 1 row for FLAG=1")
 	}
 
+	// Check if using native BOOLEAN or NUMBER(1)
+	var columnType string
+	DB.Raw(`SELECT DATA_TYPE FROM USER_TAB_COLUMNS 
+            WHERE TABLE_NAME = 'BOOLEAN_TESTS' AND COLUMN_NAME = 'FLAG'`).Scan(&columnType)
+
 	var gotStr []BooleanTest
-	if err := DB.Where("FLAG = 'true'").Find(&gotStr).Error; err == nil {
-		t.Errorf("expected ORA-01722 when comparing NUMBER to string literal")
+	err := DB.Where("FLAG = 'true'").Find(&gotStr).Error
+
+	if columnType == "NUMBER" {
+		// For NUMBER(1), expect error
+		if err == nil {
+			t.Errorf("expected ORA-01722 when comparing NUMBER to string literal")
+		}
+	} else {
+		// For BOOLEAN, it's valid
+		if err != nil {
+			t.Errorf("unexpected error for BOOLEAN type: %v", err)
+		}
 	}
 }