Removed isFinite method of Lodash

Author: fayyazarshad

packages/optimizely-sdk/lib/utils/fns/index.js

@@ -46,7 +46,7 @@ module.exports = {
     return Math.round(new Date().getTime());
   },
   isFinite: function(number) {
-    return _isFinite(number) && Math.abs(number) <= MAX_NUMBER_LIMIT;
+    return typeof number == 'number' && Math.abs(number) <= MAX_NUMBER_LIMIT;
   },
   keyBy: function(arr, key) {
     if (!arr) return {};

packages/optimizely-sdk/lib/utils/fns/index.tests.js

@@ -25,6 +25,8 @@ describe('lib/utils/fns', function() {
         assert.isFalse(fns.isFinite(Infinity));
         assert.isFalse(fns.isFinite(-Infinity));
         assert.isFalse(fns.isFinite(NaN));
+        assert.isFalse(fns.isFinite(undefined));
+        assert.isFalse(fns.isFinite('3'));
         assert.isFalse(fns.isFinite(Math.pow(2, 53) + 2));
         assert.isFalse(fns.isFinite(-Math.pow(2, 53) - 2));
       });