Skip to content

Commit 32a0c10

Browse files
Code review changes
1 parent 554773e commit 32a0c10

File tree

5 files changed

+329
-447
lines changed

5 files changed

+329
-447
lines changed

packages/optimizely-sdk/lib/plugins/odp/odp_config.ts

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { ODP_CONFIG_STATE } from '../../utils/enums';
18-
1917
export class OdpConfig {
2018
/**
2119
* Host of ODP audience segments API.
@@ -59,27 +57,10 @@ export class OdpConfig {
5957
return this._segmentsToCheck;
6058
}
6159

62-
/**
63-
* Indicates whether ODP is integrated for the project
64-
* @private
65-
*/
66-
private _odpServiceIntegrated = ODP_CONFIG_STATE.UNDETERMINED;
67-
6860
constructor(apiKey: string, apiHost: string, segmentsToCheck?: string[]) {
6961
this._apiKey = apiKey;
7062
this._apiHost = apiHost;
7163
this._segmentsToCheck = segmentsToCheck ?? [];
72-
this._odpServiceIntegrated = OdpConfig.determineOdpServiceIntegration(this._apiKey, this.apiHost);
73-
}
74-
75-
/**
76-
* Determine the value of Service Integration enum
77-
* @param apiKey ODP API Key
78-
* @param apiHost Server host of the API
79-
* @private
80-
*/
81-
private static determineOdpServiceIntegration(apiKey: string, apiHost: string): ODP_CONFIG_STATE {
82-
return apiKey && apiHost ? ODP_CONFIG_STATE.INTEGRATED : ODP_CONFIG_STATE.NOT_INTEGRATED;
8364
}
8465

8566
/**
@@ -90,8 +71,6 @@ export class OdpConfig {
9071
* @returns true if configuration was updated successfully
9172
*/
9273
public update(apiKey: string, apiHost: string, segmentsToCheck: string[]): boolean {
93-
this._odpServiceIntegrated = OdpConfig.determineOdpServiceIntegration(apiKey, apiHost);
94-
9574
if (this._apiKey === apiKey && this._apiHost === apiHost && this._segmentsToCheck === segmentsToCheck) {
9675
return false;
9776
} else {

packages/optimizely-sdk/lib/plugins/odp/odp_event_dispatcher.ts

Lines changed: 0 additions & 299 deletions
This file was deleted.

0 commit comments

Comments
 (0)