did naming changes

Author: mnoman09

core-api/src/main/java/com/optimizely/ab/Optimizely.java

@@ -669,22 +669,22 @@ String getFeatureVariableValueForType(@Nonnull String featureKey,
 
         Object convertedValue = convertStringToType(variableValue, variableType);
         Map<String, Object> decisionInfo = new HashMap<>();
-        decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.FEATURE_KEY.toString(), featureKey);
-        decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.FEATURE_ENABLED.toString(), featureEnabled);
-        decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.VARIABLE_KEY.toString(), variableKey);
-        decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.VARIABLE_TYPE.toString(), variableType);
-        decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.VARIABLE_VALUE.toString(), convertedValue);
+        decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.FEATURE_KEY.toString(), featureKey);
+        decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.FEATURE_ENABLED.toString(), featureEnabled);
+        decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.VARIABLE_KEY.toString(), variableKey);
+        decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.VARIABLE_TYPE.toString(), variableType);
+        decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.VARIABLE_VALUE.toString(), convertedValue);
         if (featureDecision.decisionSource != null && featureDecision.decisionSource.equals(FeatureDecision.DecisionSource.EXPERIMENT)) {
-            decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.SOURCE_EXPERIMENT_KEY.toString(), featureDecision.experiment.getKey());
-            decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.SOURCE_VARIATION_KEY.toString(), featureDecision.variation.getKey());
-            decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.SOURCE.toString(), featureDecision.decisionSource);
+            decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.SOURCE_EXPERIMENT_KEY.toString(), featureDecision.experiment.getKey());
+            decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.SOURCE_VARIATION_KEY.toString(), featureDecision.variation.getKey());
+            decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.SOURCE.toString(), featureDecision.decisionSource);
         } else {
-            decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.SOURCE_EXPERIMENT_KEY.toString(), null);
-            decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.SOURCE_VARIATION_KEY.toString(), null);
-            decisionInfo.put(DecisionInfoEnums.GetFeatureVariableDecisionInfo.SOURCE.toString(), FeatureDecision.DecisionSource.ROLLOUT);
+            decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.SOURCE_EXPERIMENT_KEY.toString(), null);
+            decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.SOURCE_VARIATION_KEY.toString(), null);
+            decisionInfo.put(DecisionInfoEnums.FeatureVariableDecisionInfo.SOURCE.toString(), FeatureDecision.DecisionSource.ROLLOUT);
         }
         notificationCenter.sendNotifications(NotificationCenter.NotificationType.Decision,
-            NotificationCenter.OnDecisionNotificationType.GET_FEATURE_VARIABLE.toString(),
+            NotificationCenter.DecisionNotificationType.FEATURE_VARIABLE.toString(),
             userId,
             copiedAttributes,
             decisionInfo);

core-api/src/main/java/com/optimizely/ab/notification/DecisionInfoEnums.java

@@ -17,7 +17,7 @@
 package com.optimizely.ab.notification;
 
 public class DecisionInfoEnums {
-    public enum GetFeatureVariableDecisionInfo {
+    public enum FeatureVariableDecisionInfo {
         SOURCE_EXPERIMENT_KEY("source_experiment_key"),
         SOURCE_VARIATION_KEY("source_variation_key"),
         FEATURE_KEY("feature_key"),
@@ -29,7 +29,7 @@ public enum GetFeatureVariableDecisionInfo {
 
         private final String key;
 
-        GetFeatureVariableDecisionInfo(String key) {
+        FeatureVariableDecisionInfo(String key) {
             this.key = key;
         }
 

core-api/src/main/java/com/optimizely/ab/notification/DecisionNotificationListenerInterface.java

@@ -27,7 +27,7 @@ public interface DecisionNotificationListenerInterface {
      * @param type         - The notification type.
      * @param userId       - The userId passed into activate.
      * @param attributes   - The filtered attribute list passed into activate
-     * @param decisionInfo - The decision Information containing all parameters passed in api.
+     * @param decisionInfo - The decision information containing all parameters passed in API.
      */
     void onDecision(@Nonnull String type,
                     @Nonnull String userId,

core-api/src/main/java/com/optimizely/ab/notification/NotificationCenter.java

@@ -33,14 +33,14 @@
  * more flexible.
  */
 public class NotificationCenter {
-    public enum OnDecisionNotificationType {
-        IS_FEATURE_ENABLED("feature"),
-        GET_FEATURE_VARIABLE("feature_variable"),
+    public enum DecisionNotificationType {
+        FEATURE("feature"),
+        FEATURE_VARIABLE("feature_variable"),
         EXPERIMENT("experiment");
 
         private final String key;
 
-        OnDecisionNotificationType(String key) {
+        DecisionNotificationType(String key) {
             this.key = key;
         }