-
Notifications
You must be signed in to change notification settings - Fork 1.8k
update golang docs on CRD scoping #4812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CustomResourceDefinition (CRD) scope can also be changed for cluster-scoped operators so that there is only a single | ||
instance (for a given name) of the Custom Resource (CR) to manage across the cluster. | ||
Custom Resource Definitions (CRDs) contain a scope field that determines whether the resulting Custom Resource (CR) | ||
is cluster or namespace scoped. Operators can be build making use of this feature that then operator either on the entire cluster, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operators can be built using this feature to ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, i don't know what happened there. thanks for the catch.
Signed-off-by: Jonathan Berkhahn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of suggestions, the main themes being:
- To clarify that operator scope != CRD scope
- Go vs. non-Go configuration
website/content/en/docs/building-operators/golang/crds-scope.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/building-operators/golang/crds-scope.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/building-operators/golang/crds-scope.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/building-operators/golang/crds-scope.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/building-operators/golang/crds-scope.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/building-operators/golang/crds-scope.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/building-operators/golang/crds-scope.md
Outdated
Show resolved
Hide resolved
website/content/en/docs/building-operators/golang/crds-scope.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Stroczynski <[email protected]> Signed-off-by: Jonathan Berkhahn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
Update the docs to discuss the various ways golang operators can control the scope of their CRD
Motivation for the change:
see issue #3684