Skip to content

WIP POC To solve flake - fix: ci - install kustomize in the CI #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 21, 2020

Description of the change:
Install kustomize in the CI

Motivation for the change:

Fix: https://travis-ci.org/github/operator-framework/operator-sdk/jobs/737695550#L327-L337

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@camilamacedo86 camilamacedo86 changed the title fix: ci - install kb in the CI fix: ci - install kustomize in the CI Oct 21, 2020
@camilamacedo86
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2020
@camilamacedo86 camilamacedo86 changed the title fix: ci - install kustomize in the CI To solve flake - fix: ci - install kustomize in the CI Oct 21, 2020
@joelanford
Copy link
Member

I very much disagree with this change.

Any test prerequisites or setup should be done in make targets. This type of thing makes our CI environment different from our local test environment, which was one of the main motivations for #4023.

Moreover, by installing kustomize outside of the project makefile we are no longer exercising a component of our e2e test, which is to ensure that the make kustomize target works.

@estroz
Copy link
Member

estroz commented Oct 21, 2020

I don’t see what the problem is. The only place kustomize is needed in the sanity tests is in the samples generator, which scaffolds a project. When any make command is run that requires kustomize, it will be installed by make kustomize. If that is not happening, there is a bug in a plugin somewhere.

@joelanford
Copy link
Member

@estroz That's exactly what happens.

It seems like there's a flake with it though: https://travis-ci.org/github/operator-framework/operator-sdk/jobs/737438343#L538

Not really clear what's causing that failure, but my guess would be the go get command.

@camilamacedo86 camilamacedo86 changed the title To solve flake - fix: ci - install kustomize in the CI WIP POC To solve flake - fix: ci - install kustomize in the CI Oct 21, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2020
@camilamacedo86
Copy link
Contributor Author

Closing this one. I do not think that it will solve the problem anyway.
Travis has been not nice from yesterday to today.

@camilamacedo86 camilamacedo86 deleted the fix-ci-km branch October 21, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants