*: clean up samples #4035
*: clean up samples #4035
Conversation
|
|
||
| *\.DS_Store |
| @@ -43,7 +41,7 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| samplesPath := filepath.Join(currentPath, testdata) | |||
| samplesPath := filepath.Join(currentPath, "testdata") | |||
There was a problem hiding this comment.
I caught this error on the ansible generator, missed it here. Good catch.
|
|
||
| // Clean up built binaries, if any. | ||
| pkg.CheckError("cleaning up", os.RemoveAll(filepath.Join(mh.ctx.Dir, "bin"))) |
There was a problem hiding this comment.
Also, we should add this to the gitignore. @camilamacedo86 is doing that in her PR, so no change needed, just FYI.
There was a problem hiding this comment.
I think we will need anyway. To solve the problem in the sanity I added git diff --exit-code -- . ':!testdata/go/memcached-operator/bin/*' since the bin will be gen again in the CI process.
However, the sanity sh will be also be removed in the #4023
estroz
force-pushed
the
chore/cleanup-samples
branch
from
9dfdf2f to
03271be
Compare
|
|
||
| // NewSampleContextWithTestContext returns a SampleContext containing the kubebuilder TestContext informed | ||
| // It is useful to allow the samples code be re-used in the e2e tests. | ||
| func NewSampleContextWithTestContext(tc *testutils.TestContext) (s SampleContext, err error) { | ||
| s.TestContext = *tc | ||
| return s, err | ||
| } |
There was a problem hiding this comment.
it is usefiul for the e2e test.
I am ok to remove that here but it will be added in the next follow-ups again.
| @@ -68,7 +68,7 @@ operator-sdk init --domain example.com --repo github.com/example-inc/memcached-o | |||
|
|
|||
| ## Check if your project is multi-group | |||
|
|
|||
| Before we start to create the APIs, check if your project has more than one group such as : `foo.example.com/v1` and `crew.example.com/v1`. If you intend to still working on with multiple groups in your project, then add the line | |||
There was a problem hiding this comment.
Sidenote, maybe we ought to add these style checks in our linter to make reviews easier.
There was a problem hiding this comment.
Let's track this need.
Description of the change:
memcached_controller.go.tmplmakerunsMotivation for the change: fixes CI and remove unnecessary files
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs