Only add explicit -mod=vendor if needed #2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-mod=vendor is not needed if it's already set in GOFLAGS. So lets not set it unless it's needed. This is an issue for commands such as `go test` and `go vet` ( see: golang/go#32471 ). This avois such an issue.
openshift-ci-robot
added
the
size/XS
This takes into us the suggestions from @estroz and adds the relevant comments for the addition of the -mod=vendor GOFLAG Co-Authored-By: Eric Stroczynski <[email protected]>
openshift-ci-robot
added
size/S
|
@estroz thanks for the suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
-mod=vendor is not needed if it's already set in GOFLAGS. So let's not
set it unless it's needed.
This is an issue for commands such as
go testandgo vet(see golang/go#32471 ). This avoids such an
issue.
Motivation for the change:
With the enforcement of
GOFLAGS=-mod=vendorin openshift, some projects got broken given that environment variable being set by default and operator-sdk setting that explicitly if the vendor directory exists..