*: remove broken and unnecessary Go env for v0.12.x #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Removes use of GO111MODULE and GOPROXY environment variables in build and test scripts.
Motivation for the change:
Now that we have updated SDK to support Go 1.13, these environment variables are no longer necessary.
go.modfile is considered a go module unless GO111MODULE is explicitly set tooffhttps://proxy.golang.org,direct. Addingdirectas an alternative also incidentally solves a problem with resolving branch names (e.g.v0.12.x) when used inrequireblocks.