Skip to content

example: Fix incorrect path of log package; Fix incorrect usage of me… #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

BIAOXYZ
Copy link

@BIAOXYZ BIAOXYZ commented Sep 13, 2019

Description of the change:

  1. Fix the incorrect package path:
  • "sigs.k8s.io/controller-runtime/pkg/log" should be "sigs.k8s.io/controller-runtime/pkg/runtime/log";
  • Add package "k8s.io/apimachinery/pkg/labels" since it is used.
  1. Fix some incorrect references of client object:
  • client.ListOption should be client.ListOptions;
  • the sequence of parameters in client.List is also incorrect before.

Motivation for the change:

Closes #1907

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2019
@openshift-ci-robot
Copy link

Hi @BIAOXYZ. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Member

estroz commented Sep 13, 2019

@BIAOXYZ we recently bumped controller-runtime to v0.2.0, which uses the current log package path. It seems your module setup is pulling the incorrect controller-runtime version for your operator-sdk version, as this bump is only in master. This PR reverts changes we recently made during the bump.

@estroz estroz closed this Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot load sigs.k8s.io/controller-runtime/pkg/log when build image or start use "up local"
3 participants