Skip to content

hack/tests/scaffolding/scaffold-memcached.go: remove go.mod in SDK repo hack #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 10, 2019

Description of the change: remove code that creates go.mod in a local SDK repo if one does not exist.

Motivation for the change: no longer needed now that #1566 is merged (I believe this was removed then accidentally added back on a rebase).

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2019
Copy link
Contributor

@AlexNPavel AlexNPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@estroz estroz merged commit 1cde3f3 into operator-framework:master Jul 11, 2019
@estroz estroz deleted the e2e-remove-modfile-hack branch July 11, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants