Skip to content

ci/tests/e2e-ansible-scaffold-hybrid.sh: use add_go_mod_replace instead of go mod edit #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ci/tests/e2e-ansible-scaffold-hybrid.sh: use add_go_mod_replace instead of go mod edit #1662

wants to merge 2 commits into from

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 10, 2019

Description of the change: use add_go_mod_replace instead of go mod edit directly in ci/tests/e2e-ansible-scaffold-hybrid.sh

Motivation for the change: go mod edit will error if there are any unresolved dependencies in go.mod.

@estroz estroz added the kind/bug Categorizes issue or PR as related to a bug. label Jul 10, 2019
@estroz estroz requested review from AlexNPavel and hasbro17 July 10, 2019 21:13
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2019
@estroz estroz changed the title ci/tests/e2e-ansible-scaffold-hybrid.sh: use add_go_mod_replace inste… ci/tests/e2e-ansible-scaffold-hybrid.sh: use add_go_mod_replace instead of go mod edit Jul 10, 2019
AlexNPavel
AlexNPavel approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@AlexNPavel AlexNPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2019
@estroz
Copy link
Member Author

estroz commented Jul 10, 2019

Closed by #1566

@estroz estroz closed this Jul 10, 2019
@estroz estroz deleted the modules-ci-update branch July 10, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexNPavel AlexNPavel AlexNPavel approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@lilic lilic Awaiting requested review from lilic

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@AlexNPavel AlexNPavel

Labels
kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estroz @openshift-ci-robot @AlexNPavel