-
Notifications
You must be signed in to change notification settings - Fork 1.8k
hack/ci/setup-build-dependencies.sh: add setup script in SDK repo #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/ci/setup-build-dependencies.sh: add setup script in SDK repo #1572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Any reasons why we are using 0.5.0 and not latest 0.5.4 release?
@lilic Probably just because the original command hasn't been updated in awhile. I'll bump the version. |
To test it you can try to bump it in our .travis.yaml to see if we run into any problems. I wanted to suggest calling this script there, but since we are moving away from travis doesn't make much sense I guess. |
/lgtm |
@lilic I bumped to I also updated |
@joelanford yes noticed that as well, not sure what happened in that "release". Still lgtm on green of course 👍 |
Description of the change:
Adds a setup script that can be used in OpenShift CI
Motivation for the change:
We currently hard-code the
dep
setup commands in the openshift/release repo.Once this script is merged into master, we can update the OpenShift CI configuration to use it, which then gives us the flexibility to change the test setup from the SDK repo, rather than having to make coordinating changes in openshift/release.
This will be helpful in migrating the SDK from using
dep
to go modules (see #1566)/cc @AlexNPavel