Skip to content

hack/ci/setup-build-dependencies.sh: add setup script in SDK repo #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joelanford
Copy link
Member

Description of the change:
Adds a setup script that can be used in OpenShift CI

Motivation for the change:
We currently hard-code the dep setup commands in the openshift/release repo.

Once this script is merged into master, we can update the OpenShift CI configuration to use it, which then gives us the flexibility to change the test setup from the SDK repo, rather than having to make coordinating changes in openshift/release.

This will be helpful in migrating the SDK from using dep to go modules (see #1566)

/cc @AlexNPavel

@joelanford joelanford added the area/testing Issue related to testing the operator-sdk and subcomponents label Jun 19, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2019
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Any reasons why we are using 0.5.0 and not latest 0.5.4 release?

@joelanford
Copy link
Member Author

@lilic Probably just because the original command hasn't been updated in awhile. I'll bump the version.

@lilic
Copy link
Member

lilic commented Jun 19, 2019

@lilic Probably just because the original command hasn't been updated in awhile. I'll bump the version.

To test it you can try to bump it in our .travis.yaml to see if we run into any problems. I wanted to suggest calling this script there, but since we are moving away from travis doesn't make much sense I guess.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2019
@lilic
Copy link
Member

lilic commented Jun 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
@joelanford
Copy link
Member Author

@lilic I bumped to v0.5.3. Looks like v0.5.4 isn't quite released or something. There are no binaries on the dep release page for it.

I also updated .travis.yml so we can make sure it still works. I also thought about using this script in .travis.yml, but we also do things slightly different there (e.g. use travis_retry dep ensure -v instead of make dep)

@lilic
Copy link
Member

lilic commented Jun 19, 2019

@joelanford yes noticed that as well, not sure what happened in that "release".

Still lgtm on green of course 👍

@joelanford joelanford merged commit 78f5488 into operator-framework:master Jun 19, 2019
@joelanford joelanford deleted the openshift-ci-setup-script branch June 19, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issue related to testing the operator-sdk and subcomponents lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants