Use Duration over int for resyncPeriod

[olvesh]

operator-sdk/pkg/sdk/api.go

Line 43 in 9314564

func Watch(apiVersion, kind, namespace string, resyncPeriod int) {

and

operator-sdk/pkg/sdk/informer.go

Line 48 in 9314564

func NewInformer(resourcePluralName, namespace string, resourceClient dynamic.ResourceInterface, resyncPeriod int, c *metrics.Collector) Informer {

should use time.Duration for resyncPeriod rather than an int that gets multiplied by time.Second in NewInformer method:

operator-sdk/pkg/sdk/informer.go

Line 57 in 9314564

resyncDuration := time.Duration(resyncPeriod) * time.Second

[olvesh]

Say I want to do an operator syncing every hour, my instinct is to write:

resync := 60 * time.Minute

This little oversight will in this case cause the following differences:

=== RUN   Test
1 hours 0 minutes 0 seconds
33390 days 2 hours 40 minutes 26 seconds
--- PASS: Test (0.00s)
PASS

[hasbro17]

@olvesh Closing this as it's a duplicate of #345