Skip to content

resyncPeriod for sdk.Watch() is an integer rather then time.Duration #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzelinskie opened this issue Jul 12, 2018 · 1 comment
Closed

resyncPeriod for sdk.Watch() is an integer rather then time.Duration #345

jzelinskie opened this issue Jul 12, 2018 · 1 comment
Labels
design

Comments

@jzelinskie
Copy link

This parameter eventually gets converted to a time.Duration before it's passed to an Informer. The API would be easier to use and understand if we maintained this type information throughout the SDK.
@hasbro17 hasbro17 mentioned this issue Aug 20, 2018
Closed
@hasbro17
Copy link
Contributor

@theishshah This should be a simpler change that you can follow up on after #418

@theishshah theishshah mentioned this issue Aug 24, 2018
Merged
@estroz estroz closed this as completed Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jzelinskie @hasbro17 @theishshah @estroz