This repository was archived by the owner on Nov 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 131
Upgrade version + few improvements #72
Merged
jmrodri
merged 5 commits into
operator-framework:master
from
camilamacedo86:upgrade-version
Sep 18, 2019
Merged
Upgrade version + few improvements #72
jmrodri
merged 5 commits into
operator-framework:master
from
camilamacedo86:upgrade-version
Sep 18, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrodri
suggested changes
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes to the README. The rest looks okay to me.
@echo ... Running with the --debug param ... | ||
- operator-sdk test local ./test/e2e --debug | ||
@echo ... Running with the --verbose param ... | ||
- operator-sdk test local ./test/e2e --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefile
looks good.
The operator looks good, fan of the new Makefile! Agree with Jesus about the small comments on the Read Me |
Hi @theishshah and @jmrodri, Really tks for your review. All suggestions are applied. Cheers, |
jmrodri
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
required for the following as well:
What
Steps to verify
operator-sdk build
make install
and check that the Memcached pods are deployed and runningFollowing the local tests performed with the image
cmacedo/memcached-operator:operator-sdk-samples