Skip to content
This repository was archived by the owner on Nov 18, 2020. It is now read-only.

Upgrade version + few improvements #72

Merged
merged 5 commits into from
Sep 18, 2019
Merged

Upgrade version + few improvements #72

merged 5 commits into from
Sep 18, 2019

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Sep 5, 2019

Motivation

required for the following as well:

What

  • Upgrade go example from 0.6 to operator-sdk version: v0.10.0, commit: ff80b17737a6a0aade663e4827e8af3ab5a21170
  • Add makefile in order to be easier to test the example and clarifies how to use it
  • Add the new version of olm-catalogue files
  • Change the Readme

Steps to verify

  • Build an image with operator-sdk build
  • Run make install and check that the Memcached pods are deployed and running

Following the local tests performed with the image cmacedo/memcached-operator:operator-sdk-samples

Screenshot 2019-09-05 at 23 13 03

@camilamacedo86 camilamacedo86 changed the title Upgrade version + few improvements WIP: Upgrade version + few improvements Sep 6, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2019
@camilamacedo86 camilamacedo86 self-assigned this Sep 6, 2019
@camilamacedo86 camilamacedo86 changed the title WIP: Upgrade version + few improvements Upgrade version + few improvements Sep 6, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2019
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes to the README. The rest looks okay to me.

@echo ... Running with the --debug param ...
- operator-sdk test local ./test/e2e --debug
@echo ... Running with the --verbose param ...
- operator-sdk test local ./test/e2e --verbose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile looks good.

@theishshah
Copy link
Member

The operator looks good, fan of the new Makefile! Agree with Jesus about the small comments on the Read Me

@camilamacedo86
Copy link
Contributor Author

Hi @theishshah and @jmrodri,

Really tks for your review. All suggestions are applied.
Please, feel free to check and let me know if we can merge it.

Cheers,

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2019
@jmrodri jmrodri merged commit f21fdc7 into operator-framework:master Sep 18, 2019
@camilamacedo86 camilamacedo86 deleted the upgrade-version branch September 19, 2019 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants