updating dependencies to support k8s 1.33 #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam D. Cornett <[email protected]>
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
- Coverage 88.55% 87.98% -0.58%
==========================================
Files 18 18
Lines 699 699
==========================================
- Hits 619 615 -4
- Misses 67 71 +4
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -41,7 +41,7 @@ func ExampleNewPause() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| c, err := controller.NewUnmanaged("pod", mgr, controller.Options{ | |||
| c, err := controller.NewUnmanaged("pod", controller.Options{ | |||
There was a problem hiding this comment.
It seems right since the mgr option was removed here: kubernetes-sigs/controller-runtime#3141
Merged
via the queue into
operator-framework:main
with commit Jun 21, 2025
44e6f81
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: