Skip to content

🌱 Remove test-operator.v2.0.0 fixture #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

perdasilva
Copy link
Contributor

Description

Removes the test-operator v2.0.0 fixture and uses the v1.0.0 fixture instead.
Renames test-operator.v2.0.0 to v1.3.0 in the v2 catalog and updates the e2e test accordingly.
Moves the v2.0.0 configmap into the v1.0.0 bundle and updates the e2e test accordingly.

Motivation: the only difference between v1.0.0 and v2.0.0 is that the configmap in v2.0.0 has a different annotation. There are no breaking API changes or anything. Once we move to a more fleshed out test-operator, v2.0.0 will have breaking changes and webhooks (at least for conversion). Since webhooks are not GA yet, this also presents a some issues since we cannot such a v2 in the current e2es.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva requested a review from a team as a code owner July 14, 2025 16:19
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit c84160a
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68752e22d55d1c0008b6f707
😎 Deploy Preview https://deploy-preview-2093--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.49%. Comparing base (365831a) to head (c84160a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2093   +/-   ##
=======================================
  Coverage   73.49%   73.49%           
=======================================
  Files          78       78           
  Lines        7240     7240           
=======================================
  Hits         5321     5321           
  Misses       1567     1567           
  Partials      352      352           
Flag Coverage Δ
e2e 43.68% <ø> (-0.13%) ⬇️
experimental-e2e 49.79% <ø> (-0.40%) ⬇️
unit 58.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant