🌱 [MONOREPO]: Moving catalogd's metrics test to operator-controller tests #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1714 +/- ##
==========================================
- Coverage 67.66% 67.64% -0.03%
==========================================
Files 59 59
Lines 4991 4991
==========================================
- Hits 3377 3376 -1
- Misses 1367 1368 +1
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camilamacedo86
force-pushed
the
moving-e2e-tests
branch
from
93e8a7d to
a4a456a
Compare
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
tmshort
approved these changes
Feb 5, 2025
joelanford
reviewed
Feb 5, 2025
| // 4. Waits for the curl pod to become ready. | ||
| // 5. Executes a curl command from the pod to validate the metrics endpoint. | ||
| // 6. Cleans up all resources created during the test, such as the ClusterRoleBinding and curl pod. | ||
| func TestCatalogdMetricsExportedEndpoint(t *testing.T) { |
There was a problem hiding this comment.
With this all put together, is there any common functionality we can extract into helper functions?
There was a problem hiding this comment.
We definitely can improve that.
There was a problem hiding this comment.
I will do that in a follow-up so it makes it easier to review.
Merged
via the queue into
operator-framework:main
with commit Feb 5, 2025
591c73c
22 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Small step related to #1712