✨ Add support for kubectl printer columns #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless we add another `.status` field, this is what we can do. Only simple queries starting with `.` can be used. Signed-off-by: Todd Short <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1421 +/- ##
==========================================
+ Coverage 73.30% 73.45% +0.15%
==========================================
Files 42 42
Lines 3057 3063 +6
==========================================
+ Hits 2241 2250 +9
+ Misses 643 640 -3
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
everettraven
reviewed
Nov 4, 2024
| //+kubebuilder:printcolumn:name="Installed Bundle",type=string,JSONPath=`.status.install.bundle.name` | ||
| //+kubebuilder:printcolumn:name=Version,type=string,JSONPath=`.status.install.bundle.version` | ||
| //+kubebuilder:printcolumn:name="Installed",type=string,JSONPath=`.status.conditions[?(@.type=='Installed')].status` | ||
| //+kubebuilder:printcolumn:name="Progressing",type=string,JSONPath=`.status.conditions[?(@.type=='Progressing')].status` |
There was a problem hiding this comment.
Add Progressing condition reason as well?
There was a problem hiding this comment.
With that, it can get pretty wide, as it's a non-constrained string. That might be something they need to use the -o yaml for.
|
@tmshort Can you give an example of the output/outputs before and after printer columns? |
|
main: With this PR: |
m1kola
approved these changes
Nov 5, 2024
LalatenduMohanty
approved these changes
Nov 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless we add another
.statusfield, this is what we can do. Only simple queries starting with.can be used.Alternative to: #1019
Resolves #1018
Description
Reviewer Checklist