Skip to content

🌱 Define a constant for the finaliser key #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Sep 3, 2024

Description

Moving finaliser key to a constant instead of dynamically generating it. We do it the same way in catalod. Another finalisers will be added in #1207 in a similar way.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@m1kola m1kola requested a review from a team as a code owner September 3, 2024 14:32
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e0f0ccf
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66d71dfa63f74b0008124d63
😎 Deploy Preview https://deploy-preview-1209--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.53%. Comparing base (39c893c) to head (e0f0ccf).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/manager/main.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   77.55%   77.53%   -0.03%     
==========================================
  Files          36       36              
  Lines        1978     1976       -2     
==========================================
- Hits         1534     1532       -2     
  Misses        309      309              
  Partials      135      135              
Flag Coverage Δ
e2e 57.59% <50.00%> (-0.05%) ⬇️
unit 55.61% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
@tmshort tmshort added this pull request to the merge queue Sep 3, 2024
Merged via the queue into operator-framework:main with commit 5800c7f Sep 3, 2024
16 of 18 checks passed
@m1kola m1kola deleted the finaliser_key_constant branch September 4, 2024 07:02
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants