Skip to content

Commit 8785f6e

Browse files
fix conflict port for metrics replace 8443 for 6443
1 parent c8e795b commit 8785f6e

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

catalogd/cmd/manager/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ func main() {
106106
"Enable leader election for controller manager. "+
107107
"Enabling this will ensure there is only one active controller manager.")
108108
flag.StringVar(&systemNamespace, "system-namespace", "", "The namespace catalogd uses for internal state, configuration, and workloads")
109-
flag.StringVar(&catalogServerAddr, "catalogs-server-addr", ":8443", "The address where the unpacked catalogs' content will be accessible")
109+
flag.StringVar(&catalogServerAddr, "catalogs-server-addr", ":6443", "The address where the unpacked catalogs' content will be accessible")
110110
flag.StringVar(&externalAddr, "external-address", "catalogd-service.olmv1-system.svc", "The external address at which the http(s) server is reachable.")
111111
flag.StringVar(&cacheDir, "cache-dir", "/var/cache/", "The directory in the filesystem that catalogd will use for file based caching")
112112
flag.BoolVar(&catalogdVersion, "version", false, "print the catalogd version and exit")

cmd/manager/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ func main() {
103103
caCertDir string
104104
globalPullSecret string
105105
)
106-
flag.StringVar(&metricsAddr, "metrics-bind-address", "", "The address for the metrics endpoint. Requires tls-cert and tls-key. (Default: ':8443')")
106+
flag.StringVar(&metricsAddr, "metrics-bind-address", "", "The address for the metrics endpoint. Requires tls-cert and tls-key. (Default: ':6443')")
107107
flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.")
108108
flag.StringVar(&caCertDir, "ca-certs-dir", "", "The directory of TLS certificate to use for verifying HTTPS connections to the Catalogd and docker-registry web servers.")
109109
flag.StringVar(&certFile, "tls-cert", "", "The certificate file used for the metrics server. Required to enable the metrics server. Requires tls-key.")
@@ -138,7 +138,7 @@ func main() {
138138
}
139139

140140
if certFile != "" && keyFile != "" && metricsAddr == "" {
141-
metricsAddr = ":8443"
141+
metricsAddr = ":6443"
142142
}
143143

144144
ctrl.SetLogger(textlogger.NewLogger(textlogger.NewConfig()))

config/base/manager/manager.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ spec:
5252
- /manager
5353
args:
5454
- "--health-probe-bind-address=:8081"
55-
- "--metrics-bind-address=:8443"
55+
- "--metrics-bind-address=:6443"
5656
- "--leader-elect"
5757
image: controller:latest
5858
imagePullPolicy: IfNotPresent

test/e2e/metrics_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ func TestOperatorControllerMetricsExportedEndpoint(t *testing.T) {
9898
require.NoError(t, waitErr, "Error waiting for curl pod to be ready: %s", string(waitOutput))
9999

100100
t.Log("Validating the metrics endpoint")
101-
metricsURL := "https://operator-controller-controller-manager-metrics-service." + namespace + ".svc.cluster.local:8443/metrics"
101+
metricsURL := "https://operator-controller-controller-manager-metrics-service." + namespace + ".svc.cluster.local:6443/metrics"
102102
curlCmd := exec.Command(client, "exec", curlPod, "-n", namespace, "--",
103103
"curl", "-v", "-k", "-H", "Authorization: Bearer "+token, metricsURL)
104104
output, err = curlCmd.CombinedOutput()

0 commit comments

Comments
 (0)