fix: typo caffein -> caffeine #1795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
csviri
approved these changes
Mar 3, 2023
csviri
pushed a commit
that referenced
this pull request
Mar 10, 2023
csviri
pushed a commit
that referenced
this pull request
Mar 14, 2023
csviri
pushed a commit
that referenced
this pull request
Mar 15, 2023
metacosm
added a commit
that referenced
this pull request
Mar 22, 2023
metacosm
added a commit
that referenced
this pull request
Mar 27, 2023
metacosm
added a commit
that referenced
this pull request
Mar 27, 2023
csviri
pushed a commit
that referenced
this pull request
Mar 27, 2023
metacosm
added a commit
that referenced
this pull request
Mar 27, 2023
metacosm
added a commit
that referenced
this pull request
Mar 27, 2023
metacosm
added a commit
that referenced
this pull request
Mar 27, 2023
* feat: bounded cache for informers (#1718) * fix: typo caffein -> caffeine (#1795) * feat: now possible to only output non-resource related metrics Fixes #1812. * refactor: extract abstract test fixture to add tests with variations * fix: add missing annotation * tests: add more test variations * fix: make operator non-static so it's registered once per test subclass * feat: introduce builder for MicrometerMetrics, fix test * fix: exclude more tags when not collecting per resource * fix: registry should be per-instance to ensure test independence * fix: make sure we wait a little to ensure event is properly processed * fix: make things work on Java 11, format * fix: also clean metrics on finalizer removal This is needed because the finalizer will trigger a reconciliation that adds a resource-specific metric. * fix: format * refactor: extract common tags Co-authored-by: Sébastien CROCQUESEL <[email protected]> * feat: make per-resource collecting finer-grained We now still collect GVK information when per-resource collection is switched off. * fix: do not create tag for group if not present * fix: remove unreliable no-delay implementation, defaulting to 1s delay * refactor: renamed & documented factory methods to make things clearer * docs: updated metrics section for code changes * feat: avoid emitting tag on empty value * docs: update * fix: format [skip ci] * refactor: use Tag more directly, avoid unneeded work, use constants * fix: change will happen instead of might * docs: add missing timer Co-authored-by: Sébastien CROCQUESEL <[email protected]> * docs: fix wrong & missing information * refactor: add constants * fix: wording [skip ci] Co-authored-by: Attila Mészáros <[email protected]> --------- Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Sébastien CROCQUESEL <[email protected]>
csviri
pushed a commit
that referenced
this pull request
Mar 28, 2023
csviri
pushed a commit
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.