Skip to content
This repository was archived by the owner on Sep 21, 2020. It is now read-only.

Improve getting started information in order to avoid issues as 32 #46

Merged
merged 6 commits into from
Sep 24, 2019
Merged

Improve getting started information in order to avoid issues as 32 #46

merged 6 commits into from
Sep 24, 2019

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Sep 4, 2019

Motivation

What

  • Improve steps/desc in order to help users avoid issues and/or known how to solve them.
  • Add index in order to be easier to check its info.
  • Update Getting Started steps to work with 0.10+

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2019
@camilamacedo86
Copy link
Contributor Author

Hi folks @jmrodri @hasbro17 @spahl,

It worked out for the user.

Screenshot 2019-09-09 at 18 52 34

Please, let me know if it is ok for you and if we can move forward with.

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting nits mostly.

@camilamacedo86
Copy link
Contributor Author

Hi @estroz,

Really tks for your time and review. All your suggested are addressed. Please, could you check if it is ok ow for we move forward with?

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the comments Eric made, I 👍 the ones I agreed with. There is only one I 👎 where he suggested removing a line, I suggested rewording it.

There were some other items I think should be done.

memcached-operator-6b5dc697fb-t62cv 0/1 ImagePullBackOff 0 2m
```

Following the logs in the error scenario described above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the line but rewrite it. Something like this:

The error mentioned above can also be seen in the operator's logs:

show command how to get logs and show the logs here

@camilamacedo86
Copy link
Contributor Author

HI @jmrodri and @estroz,

I think that all the suggestions are addressed. Please, let me know if is anything else that should be done here for we are able to merge it. Really tks for your review and collab with.

@jmrodri
Copy link
Member

jmrodri commented Sep 24, 2019

I verified all of @estroz comments were addressed as well as mine.

@jmrodri jmrodri merged commit 7c18265 into operator-framework:master Sep 24, 2019
@camilamacedo86 camilamacedo86 deleted the ISSUE_32 branch September 24, 2019 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants