NO-ISSUE: Synchronize From Upstream Repositories #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.17.0 to 3.17.1. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.17.0...v3.17.1) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* migrate operator-controller command handling to cobra Signed-off-by: Omar Farag <[email protected]> * remove deprecated version flag handling Signed-off-by: Omar Farag <[email protected]> * fix error handling, fix lint issues and tidy go.mod Signed-off-by: Omar Farag <[email protected]> --------- Signed-off-by: Omar Farag <[email protected]>
Adds an overlay that removes the liveness and readiness probes as well as the --leader-elect flag from the operator-controller-controller-manager deployment since those will cause container restarts when the go debugger is stopped at breakpoints. Also edits the Tiltfile to use this new overlay target. Also adds our 1 existing feature flag to the new overlay. Signed-off-by: Tayler Geiger <[email protected]>
Signed-off-by: Horiodino <[email protected]> Signed-off-by: Todd Short <[email protected]>
Do ctrl.SetLogger() in init() Check klog.V(4).Enabled() in run() (after flags have been parsed) Signed-off-by: Todd Short <[email protected]>
…ller` e2e (#1757) - Removed `gingko` and `omega` from `unpack_test`. - Ensured that `unpack_test` previously under `catalogd-e2e` is now executed alongside other `operator-controller` e2e tests.
Adds a short doc on how to set up breakpoints with VSCode through Tilt. Also expands on the existing podman local environment document. Signed-off-by: Tayler Geiger <[email protected]>
Signed-off-by: dtfranz <[email protected]> UPSTREAM: <carry>: Update generate-manifests to handle new directory The `default` directory was renamed `base`. Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Alexander Greene <[email protected]>
* Remove alumni from owners * Add m1kola to approvers Signed-off-by: Mikalai Radchuk <[email protected]>
Signed-off-by: Mikalai Radchuk <[email protected]>
…ge to be consistent with ART for 4.16 Reconciling with https://github.com/openshift/ocp-build-data/tree/6250d54c4686a708ca5985afb73080e8ca9a1f7f/images/ose-olm-operator-controller.yml
* This reverts commit 3f079c4. * Includes Validating Admission Policy manifests Signed-off-by: Mikalai Radchuk <[email protected]>
…ge to be consistent with ART for 4.17 Reconciling with https://github.com/openshift/ocp-build-data/tree/4c1326094222f9209876f06833179a1b9178faf7/images/ose-olm-operator-controller.yml
Signed-off-by: everettraven <[email protected]>
to enable TLS communication with catalogd. Configure the CA certs using the configmap injection method via service-ca-operator Signed-off-by: everettraven <[email protected]>
Also `s/runtime/framework/g` in the DOWNSTREAM_OWNERS Signed-off-by: Todd Short <[email protected]>
…ge to be consistent with ART for 4.18 Reconciling with https://github.com/openshift/ocp-build-data/tree/dd68246f3237db5db458127566fc7b05b55e1660/images/ose-olm-operator-controller.yml
Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
…run by openshift/release. Signed-off-by: dtfranz <[email protected]>
Signed-off-by: dtfranz <[email protected]>
… cluster-olm-operator Signed-off-by: Joe Lanford <[email protected]>
Pass global-pull-secret to the manager container. Signed-off-by: Mikalai Radchuk <[email protected]>
The /run/secrets/kubernetes.io/serviceaccount/ directory is projected into the pod and contains the following CA certificates: * configmap/kube-root-ca.crt as ca.crt * configmap/openshift-service-ca.crt as service-ca.crt Update the --ca-certs-dir argument to reference the directory. Signed-off-by: Todd Short <[email protected]>
…alogd deployments This allows for use of the any image.config.openshift.io trusted CAs Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
…CA configmap Signed-off-by: Todd Short <[email protected]>
…tations Signed-off-by: Joe Lanford <[email protected]>
…r CAs to avoid subPath limitations" This reverts commit 548caa4.
…tations Signed-off-by: Joe Lanford <[email protected]>
The `vet` target was removed upstream. Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Todd Short <[email protected]>
…equired comments regards catalogd e2e tests
openshift-bot
added
tide/merge-method-merge
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-bot: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-bot: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-operator-framework. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test okd-scos-e2e-aws-ovn |
|
There's np need to retest |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-catalogd |
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-operator-controller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downstream repository has been updated through the following upstream commit:
The
vendor/directory has been updated and the following commits were carried:This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.
/cc @openshift/openshift-team-operator-framework