OCPBUGS-44732: br-ex with static DNS and DHCP auto-dns false

[rbbratta]

When we use static DNS with DHCP we set auto-dns: false. For configure-ovs we also need to propagate this setting to br-ex

[openshift-ci-robot]

@rbbratta: This pull request references Jira Issue OCPBUGS-44732, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When we use static DNS with DHCP we set auto-dns: false. For configure-ovs we also need to propagate this setting to br-ex

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rbbratta]

@cybertron PTAL

[openshift-ci]

@rbbratta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-ocl	2277cda	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-azure-ovn-upgrade-out-of-change	2277cda	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-upgrade-out-of-change	2277cda	link	false	/test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift-techpreview	2277cda	link	false	/test e2e-hypershift-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[cybertron]

/lgtm

This seems reasonable. We're just persisting something that was already set.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cybertron, rbbratta
Once this PR has been reviewed and has the lgtm label, please assign dkhater-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rbbratta]

May 28 04:31:26 master-0 configure-ovs.sh[2272]: + add_nm_conn ovs-if-br-ex type ovs-interface slave-type ovs-port conn.interface br-ex master 5333beab-6d52-4c4d-9ea6-20f9d5862f22 802-3-ethernet.mtu 1500 802-3-ethernet.cloned-mac-address 30:d0 ipv4.method auto ipv4.route-metric 48 ipv6.method disabled ipv6.route-metric 48 ipv4.may-fail no ipv4.dhcp-client-id mac ipv6.addr-gen-mode eui64 ipv4.dns 192.168.111.1,192.168.111.20
May 28 04:31:26 master-0 configure-ovs.sh[2272]: + nmcli c add save no con-name ovs-if-br-ex type ovs-interface slave-type ovs-port conn.interface br-ex master 5333beab-6d52-4c4d-9ea6-20f9d5862f22 802-3-ethernet.mtu 1500 802-3-ethernet.cloned-mac-address 30:d0 ipv4.method auto ipv4.route-metric 48 ipv6.method disabled ipv6.route-metric 48 ipv4.may-fail no ipv4.dhcp-client-id mac ipv6.addr-gen-mode eui64 ipv4.dns 192.168.111.1,192.168.111.20 connection.autoconnect no
May 29 17:53:22 master-0 configure-ovs.sh[2862]: ++ nmcli --get-values ipv4.ignore-auto-dns conn show 47985c50-3026-5b7c-a140-fdc2f2b62653
May 29 17:53:22 master-0 configure-ovs.sh[2311]: + ipv4_auto_dns=yes
May 29 17:53:22 master-0 configure-ovs.sh[2311]: + extra_if_brex_args+='ipv4.ignore-auto-dns yes '
May 29 17:53:22 master-0 configure-ovs.sh[2866]: ++ nmcli --get-values ipv6.ignore-auto-dns conn show 47985c50-3026-5b7c-a140-fdc2f2b62653
May 29 17:53:22 master-0 configure-ovs.sh[2311]: + ipv6_auto_dns=no
May 29 17:53:22 master-0 configure-ovs.sh[2311]: + extra_if_brex_args+='ipv6.ignore-auto-dns no '
May 29 17:53:22 master-0 configure-ovs.sh[2311]: + add_nm_conn ovs-if-br-ex type ovs-interface slave-type ovs-port conn.interface br-ex master 7c44a6bc-d91d-412f-acbf-4f708790637b 802-3-ethernet.mtu 1500 802-3-ethernet.cloned-mac-address 30:d0 ipv4.method auto ipv4.route-metric 48 ipv6.method disabled ipv6.route-metric 48 ipv4.may-fail no ipv4.dhcp-client-id mac ipv6.addr-gen-mode eui64 ipv4.dns 192.168.111.1,192.168.111.20 ipv4.ignore-auto-dns yes ipv6.ignore-auto-dns no
May 29 17:53:22 master-0 configure-ovs.sh[2311]: + nmcli c add save no con-name ovs-if-br-ex type ovs-interface slave-type ovs-port conn.interface br-ex master 7c44a6bc-d91d-412f-acbf-4f708790637b 802-3-ethernet.mtu 1500 802-3-ethernet.cloned-mac-address 30:d0 ipv4.method auto ipv4.route-metric 48 ipv6.method disabled ipv6.route-metric 48 ipv4.may-fail no ipv4.dhcp-client-id mac ipv6.addr-gen-mode eui64 ipv4.dns 192.168.111.1,192.168.111.20 ipv4.ignore-auto-dns yes ipv6.ignore-auto-dns no connection.autoconnect no

ipv4.dns:                               192.168.111.1,192.168.111.22
ipv4.dns-search:                        --
ipv4.dns-options:                       --
ipv4.dns-priority:                      0
ipv4.routed-dns:                        -1 (default)
ipv4.ignore-auto-dns:                   yes
ipv6.dns:                               --
ipv6.dns-search:                        --
ipv6.dns-options:                       --
ipv6.dns-priority:                      0
ipv6.routed-dns:                        -1 (default)
ipv6.ignore-auto-dns:                   no
DHCP4.OPTION[5]:                        domain_name = ostest.test.metalkube.org
DHCP4.OPTION[6]:                        domain_name_servers = 192.168.111.1
DHCP4.OPTION[12]:                       requested_domain_name = 1
DHCP4.OPTION[13]:                       requested_domain_name_servers = 1
DHCP4.OPTION[14]:                       requested_domain_search = 1
DHCP4.OPTION[18]:                       requested_nis_domain = 1

Seems to work.

[rbbratta]

/label qe-approved