Skip to content

[release-4.17] OCPBUGS-56752: Support NODEIP_HINT in IPI deployments too #5080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-56752: Support NODEIP_HINT in IPI deployments too #5080

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4973

/assign openshift-ci-robot

@cybertron
OCPBUGS-36859: Support NODEIP_HINT in IPI deployments too
c57a492 
Originally this was only enabled for UPI deployments because in IPI
we expected the node IP to match the VIP subnet. However, since then
two scenarios have come up where that may not be true:
- VSphere clusters are often deployed with VIPs that are not on the
  Machine Network
- User-namaged loadbalancers may be on any subnet
In either of these cases we currently fall back to the remote worker
behavior of selecting based on the default route. This is a problem
if there are two interfaces, both with default routes. The order of
activation can cause nondeterministic behavior.

This deliberately does not support the old KUBELET_NODEIP_HINT name
that the UPI service does because it was never a thing in IPI and
we don't need the backward compatibility with it.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 27, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-36859 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.17] OCPBUGS-56752: Support NODEIP_HINT in IPI deployments too

In response to this:

This is an automated cherry-pick of #4973

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-36859: Support NODEIP_HINT in IPI deployments too [release-4.17] OCPBUGS-56752: Support NODEIP_HINT in IPI deployments too May 27, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 27, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56752, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-56751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #4973

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mdbooth and rvanderp3 May 27, 2025 16:55
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign djoshy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift c57a492 link true /test e2e-hypershift
ci/prow/e2e-azure-ovn-upgrade-out-of-change c57a492 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-techpreview c57a492 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-vsphere-ovn-zones c57a492 link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-upi-zones c57a492 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-gcp-op c57a492 link true /test e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth Awaiting requested review from mdbooth

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@openshift-ci-robot openshift-ci-robot

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @cybertron