Skip to content

Can't import machine-config-operator #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmontleon opened this issue Jun 12, 2019 · 15 comments
Closed

Can't import machine-config-operator #848

jmontleon opened this issue Jun 12, 2019 · 15 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jmontleon
Copy link

I'm trying to import github.com/openshift/machine-config-operator/pkg/apis/machineconfiguration.openshift.io/v1

Go get fails with:

-> unzip /home/jmontleo/Documents/openshift/pkg/mod/cache/download/github.com/openshift/machine-config-operator/@v/v3.11.0+incompatible.zip: malformed file path "pkg/controller/template/test_data/templates/aws/master/files/-etc-docker-certs.d-docker-registry.default.svc:5000-ca.crt": invalid char ':'

Digging around it looks like the colon is reserved on Windows so go doesn't consider it valid.

Steps to reproduce the issue:

$ go get https://github.com/openshift/machine-config-operator
go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'
package https:/github.com/openshift/machine-config-operator: https:/github.com/openshift/machine-config-operator: invalid import path: malformed import path "https:/github.com/openshift/machine-config-operator": invalid char ':'

Describe the results you expected:
It should be possible to go get and import

Additional information you deem important (e.g. issue happens only occasionally):
golang/go#28001

Output of oc adm release info --commits | grep machine-config-operator:
N/A

Additional environment details (platform, options, etc.):
N/A

@runcom runcom added the kind/bug Categorizes issue or PR as related to a bug. label Jun 12, 2019
@runcom
Copy link
Member

runcom commented Jun 12, 2019

we're not using go mod just yet and code isn't ready to move to it right now. Guess we need to fix this anyway once kube switches to that maybe.

@ashcrow
Copy link
Member

ashcrow commented Jun 12, 2019

@runcom is there an upstream issue in kube for the move?

@runcom
Copy link
Member

runcom commented Jun 12, 2019

I need to check on it

@runcom
Copy link
Member

runcom commented Jun 17, 2019

FYI, current master doesn't have this issue since we got rid of that file specifically (test_data...)

@gildub
Copy link

gildub commented Sep 13, 2019

@runcom,

Still same issue.

I tried @master, latest commit and tag @4.2.0-201907161330 (although it's not explicitly listed, maybe it needs a release attached to it)

go list -m --versions github.com/openshift/machine-config-operator
github.com/openshift/machine-config-operator v0.0.0 v3.11.0+incompatible v4.0.0-alpha.0+incompatible v4.2.0-alpha.0+incompatible

@jhrozek
Copy link
Contributor

jhrozek commented Nov 15, 2019

The compliance operator would benefit from having this issue fixed or possible to work around. In the operator, we'd like to create MachineConfig objects as remediations for compliance issues in the cluster.

I'm still hitting the issue as of today:

go get -u github.com/openshift/machine-config-operator
go: extracting github.com/openshift/machine-config-operator v3.11.0+incompatible
-> unzip /home/jhrozek/go/pkg/mod/cache/download/github.com/openshift/machine-config-operator/@v/v3.11.0+incompatible.zip: malformed file path "pkg/controller/template/test_data/templates/aws/master/files/-etc-docker-certs.d-docker-regis
try.default.svc:5000-ca.crt": invalid char ':'
package github.com/openshift/machine-config-operator: unknown import path "github.com/openshift/machine-config-operator": unzip /home/jhrozek/go/pkg/mod/cache/download/github.com/openshift/machine-config-operator/@v/v3.11.0+incompatible.
zip: malformed file path "pkg/controller/template/test_data/templates/aws/master/files/-etc-docker-certs.d-docker-registry.default.svc:5000-ca.crt": invalid char ':'

isimluk added a commit to isimluk/compliance-operator that referenced this issue Feb 3, 2020
Even though we have

    openshift/machine-config-operator#848

I have been able to make this work.
@harche
Copy link
Contributor

harche commented Apr 5, 2020

@runcom I am writing an operator where I want to write file on a worker node using MCO, but because of this bug I am not able to import MachineConfig. I guess for now, I will follow how it's done in compliance-operator.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2020
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 4, 2020
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member

enxebre commented Jul 14, 2021

I'm facing this too, is this API not consumable atm?

@enxebre enxebre reopened this Jul 14, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2021

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gmeghnag
Copy link

gmeghnag commented Sep 21, 2021

I'm facing the same issue, but used this workaround in my go.mod:
replace github.com/openshift/machine-config-operator => github.com/openshift/machine-config-operator v0.0.1-0.20200913004441-7eba765c69c9

mohammadheib added a commit to mohammadheib/cluster-network-operator that referenced this issue Oct 7, 2022
run
```
go mod tidy
go mod vendor
```
Use replace directive in go.mod to fix a known issue [1] in MCO.
[1] openshift/machine-config-operator#848

Signed-off-by: Mohammad Heib <[email protected]>
mohammadheib added a commit to mohammadheib/cluster-network-operator that referenced this issue Oct 17, 2022
run
```
go mod tidy
go mod vendor
```
Use replace directive in go.mod to fix a known issue [1] in MCO.
[1] openshift/machine-config-operator#848

Signed-off-by: Mohammad Heib <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

10 participants