change: we now avoid running init_by_lua* in signaller processes and when testing the nginx configuration. #c04bc97

Author: thibaultcha

src/ngx_stream_lua_module.c

@@ -470,6 +470,10 @@ ngx_stream_lua_init(ngx_conf_t *cf)
 
     ngx_pool_cleanup_t         *cln;
 
+    if (ngx_process == NGX_PROCESS_SIGNALLER || ngx_test_config) {
+        return NGX_OK;
+    }
+
     lmcf = ngx_stream_conf_get_module_main_conf(cf,
                                                 ngx_stream_lua_module);
 

t/160-disable-init-by-lua.t

@@ -0,0 +1,123 @@
+use Test::Nginx::Socket::Lua::Stream;
+
+repeat_each(2);
+
+plan tests => repeat_each() * (blocks() * 2);
+
+$ENV{TEST_NGINX_HTML_DIR} ||= html_dir();
+
+my $html_dir = $ENV{TEST_NGINX_HTML_DIR};
+my $stream_config = <<_EOC_;
+    init_by_lua_block {
+        function set_up_ngx_tmp_conf()
+            local conf = [[
+                events {
+                    worker_connections 64;
+                }
+                stream {
+                    init_by_lua_block {
+                        ngx.log(ngx.ERR, "run init_by_lua")
+                    }
+                }
+            ]]
+
+            assert(os.execute("mkdir -p $html_dir/logs"))
+
+            local conf_file = "$html_dir/nginx.conf"
+            local f, err = io.open(conf_file, "w")
+            if not f then
+                ngx.log(ngx.ERR, err)
+                return
+            end
+
+            assert(f:write(conf))
+
+            return conf_file
+        end
+
+        function get_ngx_bin_path()
+            local ffi = require "ffi"
+            ffi.cdef[[char **ngx_argv;]]
+            return ffi.string(ffi.C.ngx_argv[0])
+        end
+    }
+_EOC_
+
+add_block_preprocessor(sub {
+    my $block = shift;
+
+    if (!defined $block->stream_config) {
+        $block->set_value("stream_config", $stream_config);
+    }
+});
+
+log_level("warn");
+no_long_string();
+run_tests();
+
+__DATA__
+
+=== TEST 1: ensure init_by_lua* is not run in signaller process
+--- stream_server_config
+    content_by_lua_block {
+        local conf_file = set_up_ngx_tmp_conf()
+        local nginx = get_ngx_bin_path()
+
+        local cmd = nginx .. " -p $TEST_NGINX_HTML_DIR -c " .. conf_file .. " -s reopen"
+        local p, err = io.popen(cmd)
+        if not p then
+            ngx.log(ngx.ERR, err)
+            return
+        end
+
+        local out, err = p:read("*a")
+        if not out then
+            ngx.log(ngx.ERR, err)
+
+        else
+            ngx.log(ngx.WARN, out)
+        end
+    }
+--- no_error_log eval
+qr/\[error\] .*? init_by_lua:\d+: run init_by_lua/
+
+
+
+=== TEST 2: init_by_lua* does not run when testing Nginx configuration
+--- stream_server_config
+    content_by_lua_block {
+        local conf_file = set_up_ngx_tmp_conf()
+        local nginx = get_ngx_bin_path()
+
+        local cmd = nginx .. " -p $TEST_NGINX_HTML_DIR -c " .. conf_file .. " -t"
+        local p, err = io.popen(cmd)
+        if not p then
+            ngx.log(ngx.ERR, err)
+            return
+        end
+
+        local out, err = p:read("*a")
+        if not out then
+            ngx.log(ngx.ERR, err)
+
+        else
+            ngx.log(ngx.WARN, out)
+        end
+
+        local cmd = nginx .. " -p $TEST_NGINX_HTML_DIR -c " .. conf_file .. " -T"
+        local p, err = io.popen(cmd)
+        if not p then
+            ngx.log(ngx.ERR, err)
+            return
+        end
+
+        local out, err = p:read("*a")
+        if not out then
+            ngx.log(ngx.ERR, err)
+
+        else
+            ngx.log(ngx.WARN, out)
+        end
+    }
+--- no_error_log eval
+qr/\[error\] .*? init_by_lua:\d+: run init_by_lua/