feature: client connect response #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows callers of `client:connect()` to specify a custom host header. This option also overrides the default SNI if not explicitly set. It also adds documentation and tests for the recently-added `server_name` option.
This gives the caller the ability to explicitly set the value of the Sec-WebSocket-Key header instead of having it generated randomly. For the most part this is not needed, but it is helpful for certain use-cases like integration tests and reverse proxy applications that need to be as transparent as possible with proxying websocket connections.
|
Argh, I wish the UI made it more apparent which repo you're opening the PR against. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[this was opened by mistake]