bugfix: we closed listener's fd which was closed. #1832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test case is in openresty/lua-resty-core#331 |
thibaultcha
approved these changes
Nov 28, 2020
thibaultcha
reviewed
Nov 28, 2020
thibaultcha
reviewed
Dec 2, 2020
| if (ls[i].fd != (ngx_socket_t) -1 && | ||
| ngx_close_socket(ls[i].fd) == -1) | ||
| { | ||
| ngx_log_error(NGX_LOG_WARN, ngx_cycle->log, ngx_socket_errno, |
There was a problem hiding this comment.
I'm glad that we seem to agree on the severity level; if we are to downgrade this log to warn (which I believe is appropriate), don't we ought it too to lower the below logs as well? That is, all calls to ngx_log_error that aren't followed by exit() I mean.
That said, not a blocker for this fix of course, since the above check in the condition is all this PR should need 👍
thibaultcha
approved these changes
Dec 2, 2020
ghost
pushed a commit
to Kong/kong-build-tools
that referenced
this pull request
Mar 23, 2021
Contains the patch from openresty/lua-nginx-module#1832 But applied to 1.17.8.2.
ghost
mentioned this pull request
ghost
pushed a commit
to Kong/kong-build-tools
that referenced
this pull request
Mar 24, 2021
Contains the patch from openresty/lua-nginx-module#1832 But applied to 1.17.8.2.
ghost
mentioned this pull request
ghost
pushed a commit
to Kong/kong-build-tools
that referenced
this pull request
Mar 24, 2021
Contains the patch from openresty/lua-nginx-module#1832
ghost
mentioned this pull request
ghost
pushed a commit
to Kong/kong-build-tools
that referenced
this pull request
Mar 30, 2021
Contains the patch from openresty/lua-nginx-module#1832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1806
fix #1830
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.