bugfix: first part headers will be discard when using single LF as delimiter #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spacewander Will you have a look at this? Thanks! |
spacewander
requested changes
Dec 5, 2017
t/104-req-raw-header.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 30: large headers(using single LF as linefeed) |
There was a problem hiding this comment.
I suggest to use line break instead of linefeed, since linefeed may be confused with LF.
t/104-req-raw-header.t
Outdated
| === TEST 30: large headers(using single LF as linefeed) | ||
| --- config | ||
| location /t { | ||
| content_by_lua ' |
There was a problem hiding this comment.
New test cases should use content_by_lua_block instead.
…limiter and headers number is large enough
|
@spacewander @agentzh The code has been updated. |
spacewander
approved these changes
Dec 5, 2017
|
@agentzh @spacewander ping. Any plan for this? |
|
@tokers Will have a look at this. |
agentzh
reviewed
Jan 2, 2018
|
|
||
|
|
||
|
|
||
| === TEST 31: large headers without request line(using single LF as line break) |
There was a problem hiding this comment.
Better add a space before ( for aesthetic reasons.
|
|
||
|
|
||
|
|
||
| === TEST 32: large headers with leading CRLF(using single LF as line break) |
|
|
||
|
|
||
|
|
||
| === TEST 30: large headers(using single LF as line break) |
|
|
||
|
|
||
|
|
||
| === TEST 33: large headers without request line but contains leading CRLF(using single LF as line break) |
|
@tokers Merged with fixes for the aforementioned minor issues. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.
When the delimiter is the single LF and the request has large headers,
ngx.req.raw_headerwill discard the first part headers.