-
Notifications
You must be signed in to change notification settings - Fork 90
fix: support appDir #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: support appDir #1638
Changes from 43 commits
Commits
Show all changes
209 commits
Select commit
Hold shift + click to select a range
8efc635
chore: update canary demo
ascorbic c4500c4
chore: add app-dir demo
ascorbic 2c85686
fix: resolve page deps in app dir
ascorbic d07f4a2
fix: patch duplicate declaration
ascorbic 335ee34
fix: resolve nft deps
ascorbic cceb348
feat: add support for appdir edge runtime
ascorbic 7607049
chore: update next canary and react (and change APIs)
ascorbic 2321816
fix: update patch syntax
ascorbic 1492d06
fix: include file itself in deps
ascorbic 38e118c
chore: upgrade next and remove workaround
ascorbic 9852eb2
chore: move app-dir site to canary
ascorbic f5a2979
Merge branch 'main' into mk/canary-demo
ascorbic 57fb3a6
chore: update snapshot
ascorbic 47a07da
chore: add initial app-dir tests
ascorbic b7d25bc
chore: use correct site for canary tests
ascorbic 8cc835a
Merge branch 'main' into mk/canary-demo
ascorbic 1e70c21
chore: enable plugin
ascorbic 9ccaaf2
ci: use vitest for canary e2e tests
ascorbic 190e71a
Merge branch 'main' into mk/canary-demo
ascorbic b91f352
chore: re-enable plugin
ascorbic 21520ad
chore: setup playwright
ascorbic 6d40de0
chore: wait longer when first using playwright
ascorbic 3d69f4e
chore: run tests headless
ascorbic 9e6b12e
chore: install chromium
ascorbic 2977900
chore: longer timeout
ascorbic 572de53
chore: use undici
ascorbic f6d1c48
chore: enable remaining tests
ascorbic b6d7017
chore: fix test syntax
ascorbic c34b4fb
chore: update demos
ascorbic 3ff8ecc
chore: update canary
ascorbic 9ff1d95
chore: fix 404 test
ascorbic 8397658
chore: disable test that depends on an upstream fix
ascorbic 2410ed7
chore: fix handling of "self" object
ascorbic c35db55
chore: update packages
ascorbic 622e7eb
chore: update canary
ascorbic 8cb5cc5
chore: tidy and add license for next.js code
ascorbic a4c4f84
Merge branch 'main' into mk/canary-demo
ascorbic 5c270d8
chore: handle empty static manifest
ascorbic eb785ed
Merge branch 'main' into mk/canary-demo
ascorbic ca325de
chore: downgrasde canary because of regression
ascorbic 30cd451
chore: logging for windows
ascorbic 25edbe9
Merge branch 'main' into mk/canary-demo
ascorbic 69f6ff3
Merge branch 'main' into mk/canary-demo
ascorbic 82b5999
Merge branch 'main' into mk/canary-demo
ascorbic ee962b8
Apply suggestions from code review
ascorbic 17bb6d4
Merge branch 'main' into mk/canary-demo
ascorbic ee77473
chore: update next canary
ascorbic 40480f4
chore: remove npmrc
ascorbic bff65d7
Merge branch 'main' into mk/canary-demo
ascorbic d9db615
chore: update next and react
ascorbic 410a405
chore: update test site
ascorbic 6449114
chore: update tests
ascorbic f69140d
chore: add back npmrc
ascorbic 3fe1311
fix: use globby not tiny-glob
ascorbic f646397
chore: update fixtures
ascorbic 886917e
Merge branch 'main' into mk/canary-demo
ascorbic dd14229
chore: deps
ascorbic bcb5bcb
Merge branch 'main' into mk/canary-demo
ascorbic 31347b5
chore: update tests and demo
ascorbic bbc8252
fix: correct request types
ascorbic a0c6d06
fix: skip generating lambda for edge api routes
ascorbic 0de0f1a
Merge branch 'main' into mk/canary-demo
ascorbic 0d248c1
chore: log request
ascorbic dbb94f9
chore: add runtime as dep
ascorbic 21a2983
chore: pre-version
ascorbic 54e32bb
chore: add canary to ws
ascorbic 770f77d
chore: fix build
ascorbic 415af7c
chore: fix monorepo setup
ascorbic 8a367e9
chore: upgrade
ascorbic 883e7a8
chore: react no-longer pre-bundled
ascorbic cf5b8e8
chore: remove deliberately broken demo pages
ascorbic 2f88697
fix: move pre-rendered appdir files
ascorbic 294ff05
fix: correct manifest path
ascorbic 0ecebea
chore: update demo
ascorbic e9d7d27
Merge branch 'main' into mk/canary-demo
ascorbic 72ba0c5
chore: update tests
ascorbic f7041aa
chore: add sass test
ascorbic 64a02b9
chore: update demo config
ascorbic 5b978bd
chore: skip test that also fails upstream
ascorbic 9cf9146
Merge branch 'main' into mk/canary-demo
ascorbic 631db3b
chore: update next canary
ascorbic 8810d43
chore: update use usage
ascorbic 628d52b
Merge branch 'main' into mk/canary-demo
ascorbic 04e1399
chore: update canary
ascorbic 3fbd229
fix: support loading static files for both pages and app
ascorbic 03693b5
chore: update canary
ascorbic 34f0948
chore: update canary
ascorbic 755446d
chore: final canary!
ascorbic 9a43a09
chore(deps): update demos and deps to Next 13
ascorbic cfa5a46
chore: add swc
ascorbic aab3b80
chore: switch old node tests to use node 14
ascorbic c310c57
fix: correct requestdata type
ascorbic c02aed0
chore: update next/link syntax
ascorbic 04b536c
chore: use legacy image component for now
ascorbic bc10b8b
Merge branch 'mk/next-13' into mk/canary-demo
ascorbic af56ac5
Merge branch 'main' into mk/canary-demo
ascorbic 74e80e0
chore: update demo
ascorbic 8e0c91b
Merge branch 'main' into mk/canary-demo
ascorbic c277033
Merge branch 'main' into mk/canary-demo
ascorbic 383fb95
Merge branch 'main' into mk/canary-demo
ascorbic 716bfdd
Merge branch 'main' into mk/canary-demo
ascorbic ccf97f9
chore: update canary demo
ascorbic 688d109
Merge branch 'main' into mk/canary-demo
ascorbic 2e4d2a0
chore: all the tests
ascorbic 1fada0c
chore: fix eslint
ascorbic 119acea
chore: parallelise e2e tests
ascorbic 56af7cd
chore: don't fail fast
ascorbic 1b585b3
chore: unignore modules and use node-fetch
ascorbic 6e21fb4
chore: very parallel
ascorbic 8208c99
chore: don't mock fetch :facepalm:
ascorbic 5a8e8e0
chore: remove disabled tests
ascorbic 244feb9
chore: test with node 18
ascorbic b001fa2
chore: switchable fetch
ascorbic 54c6dbd
chore: remove irrelevant tests
ascorbic a9bb106
chore: remove disabled test
ascorbic 94922e4
chore: add reporter
ascorbic a83ec22
chore: no concurrency
ascorbic 6da9677
chore: try to fix jest
ascorbic cd387b7
chore: fix test command
ascorbic a5d802f
chore: artifact file path
ascorbic 40f82a0
chore: use site build command
ascorbic 5deb9e4
chore: download artifacts
ascorbic 1aefa22
chore: report per-chunk
ascorbic a1fb9fe
chore: update syntax
ascorbic 1bad311
chore: report to summary
ascorbic 1e8b82a
chore: do annotate
ascorbic 8e738ac
chore: update and add summary
ascorbic 04d85ba
chore: rearrange
ascorbic e59241d
chore: combine tests
ascorbic ea61bb9
chore: fix test
ascorbic 5fd01b6
chore: rearrange and disable failing suites
ascorbic 00f105f
chore: skip broken ntl and fail faster
ascorbic d0aaab4
chore: disable suite
ascorbic 155bca9
chore: skip failing tests
ascorbic 703443a
chore: add ability to run disabled tests
ascorbic 8d82ad5
chore: add comments to workflow file
ascorbic b387a42
Merge branch 'main' into mk/all-the-tests
ascorbic 59f8aa2
Merge branch 'main' into mk/all-the-tests
ascorbic 5d0a5f3
chore: one worker per file
ascorbic d8f55d9
Merge branch 'mk/all-the-tests' of github.com:netlify/next-runtime in…
ascorbic 8daf9a7
chore: oops
ascorbic 585f940
chore: make path relative to test dir
ascorbic 8d4e75e
chore: conditionally skip
ascorbic f0044fe
chore: enable middleware-responses test
ascorbic 5c5a847
chore: run all tests once
ascorbic e4de44c
chore: don't run disabled tests
ascorbic f6a9699
fix: ensure responses are Responses
ascorbic 3de3b89
chore: re-enable test
ascorbic 7f0634f
chore: run all tests
ascorbic 10d46de
chore: enable another suite
ascorbic 5bf495e
fix: better headers.getAll polyfill
ascorbic cf52991
chore: enable middleware-redirects suite
ascorbic 55141ed
Merge branch 'main' into mk/all-the-tests
ascorbic 62070b8
chore: conditionally enable req body tests
ascorbic bacd775
chore: disable failing tests
ascorbic f070c64
chore: add test readme doc
ascorbic 4065399
chore: remove eslint changes
ascorbic 63b7eb4
Merge branch 'mk/all-the-tests' into mk/canary-demo
ascorbic 0f5482b
chore: add new appdir tests
ascorbic aa0a762
chore: use canary for appdir tests
ascorbic c34ce6a
chore: use extended matchers
ascorbic e22ccce
chore: increase timeout
ascorbic a4a91f8
chore: enable tests that were disabled upstream
ascorbic 72a5c54
chore: don't clobber package.json in tests
ascorbic 9001fbb
chore: set EdgeRuntime name globally
ascorbic d7ce259
chore: remove logs
ascorbic 684d5d2
chore: update tests
ascorbic 8990c5f
chore: test updates
ascorbic db56a5a
Merge branch 'main' into mk/canary-demo
ascorbic 82fea50
chore: increase timeout
ascorbic 25914f1
chore: increase timeout for site deploy
ascorbic 1b4d92d
chore: include step annotations
ascorbic cc1eb1b
chore: don't use canary demo for this
ascorbic ceba306
chore: increase timeout
ascorbic c7681d0
chore: add rewrite-to-edge demo
ascorbic b120d69
chore: deploy edge functions after cache
ascorbic 9c447dd
chore: refresh lockfile
ascorbic 42720de
chore: enable rewrite tests
ascorbic ed3557e
chore: update tests
ascorbic d5088b0
chore: update tests
ascorbic 41c1858
chore: enable rsc tests
ascorbic d2c6a7c
chore: skip tests
ascorbic 6289524
chore: re-enable dev check
ascorbic 83ea1a4
Merge branch 'main' into mk/canary-demo
ascorbic 5331918
chore: update lockfile
ascorbic 62a6049
Merge branch 'main' into mk/canary-demo
ascorbic 8b8eadb
chore: run workflows only on new pr and pr sync
ascorbic cd9f1eb
chore: add log about testing appdir
ascorbic 8341be8
chore: only use cache: manual if site uses appDir
ascorbic e7ba4aa
chore: changes from review
ascorbic 96be7c7
Merge branch 'main' into mk/canary-demo
ascorbic 26a7298
Merge branch 'main' into mk/canary-demo
ascorbic 43d5c8f
ci: fix e2e test
ascorbic 25bd981
fix: correctly match static files against rewrites
ascorbic d525dfc
Merge branch 'main' into mk/canary-demo
ascorbic e4db114
chore: upgrade next
ascorbic 5ca66a4
Merge branch 'main' into mk/canary-demo
ascorbic 1e4c31c
chore: increase timeout
ascorbic 13d3c73
chore: extend timeout
ascorbic 1c3cc3e
fix: handle prefetch correctly
ascorbic ba3cc95
chore: rmeove log
ascorbic 54d9a91
chore: log env
ascorbic 4d78687
chore: enough with these rules
ascorbic 5a3aae7
chore: fix base url
ascorbic 1234cfd
chore: try with all tests
ascorbic 4e89a33
chore: don't run disabled tests
ascorbic f7c91cb
Merge branch 'main' into mk/canary-demo
ascorbic b972d3d
Merge branch 'main' into mk/canary-demo
ascorbic 7abc8b8
fix: vary on prefetch
ascorbic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
legacy-peer-deps=true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,2 @@ | ||
This is a [Next.js](https://nextjs.org/) project bootstrapped with [`create-next-app`](https://github.com/vercel/next.js/tree/canary/packages/create-next-app). | ||
|
||
## Getting Started | ||
|
||
First, run the development server: | ||
|
||
```bash | ||
npm run dev | ||
# or | ||
yarn dev | ||
``` | ||
|
||
Open [http://localhost:3000](http://localhost:3000) with your browser to see the result. | ||
|
||
You can start editing the page by modifying `pages/index.js`. The page auto-updates as you edit the file. | ||
|
||
[API routes](https://nextjs.org/docs/api-routes/introduction) can be accessed on [http://localhost:3000/api/hello](http://localhost:3000/api/hello). This endpoint can be edited in `pages/api/hello.js`. | ||
|
||
The `pages/api` directory is mapped to `/api/*`. Files in this directory are treated as [API routes](https://nextjs.org/docs/api-routes/introduction) instead of React pages. | ||
|
||
## Learn More | ||
|
||
To learn more about Next.js, take a look at the following resources: | ||
|
||
- [Next.js Documentation](https://nextjs.org/docs) - learn about Next.js features and API. | ||
- [Learn Next.js](https://nextjs.org/learn) - an interactive Next.js tutorial. | ||
|
||
You can check out [the Next.js GitHub repository](https://github.com/vercel/next.js/) - your feedback and contributions are welcome! | ||
Based on [Next.js app dir e2e tests](https://github.com/vercel/next.js/blob/canary/test/e2e/app-dir/app). | ||
ascorbic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
[License](https://github.com/vercel/next.js/blob/canary/license.md). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default function AnotherPage(props) { | ||
return ( | ||
<> | ||
<p>hello from newroot/dashboard/another</p> | ||
</> | ||
) | ||
} |
19 changes: 19 additions & 0 deletions
19
demos/canary/app/(newroot)/dashboard/project/[projectId]/page.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { experimental_use as use } from 'react' | ||
|
||
function getData({ params }) { | ||
return { | ||
now: Date.now(), | ||
params, | ||
} | ||
} | ||
|
||
export default function Page(props) { | ||
const data = use(getData(props)) | ||
|
||
return ( | ||
<> | ||
<p>/dashboard/project/[projectId]</p> | ||
<p id="props">{JSON.stringify(data)}</p> | ||
</> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { experimental_use as use } from 'react' | ||
|
||
async function getData() { | ||
return { | ||
world: 'world', | ||
} | ||
} | ||
|
||
export default function Root({ children }) { | ||
const { world } = use(getData()) | ||
|
||
return ( | ||
<html className="this-is-another-document-html"> | ||
<head> | ||
<title>{`hello ${world}`}</title> | ||
</head> | ||
<body className="this-is-another-document-body">{children}</body> | ||
</html> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default function ChangelogPage(props) { | ||
return ( | ||
<> | ||
<p>hello from app/dashboard/changelog</p> | ||
</> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default function HelloPage(props) { | ||
return ( | ||
<> | ||
<p>hello from app/dashboard/rootonly/hello</p> | ||
</> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// components under catch-all should not throw errors | ||
export default () => <p id="widget">widget</p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import Widget from './components/widget' | ||
|
||
export default function Page({ params }) { | ||
return ( | ||
<> | ||
<h1 id="text" data-params={params.slug.join('/') ?? ''}> | ||
hello from /catch-all/{params.slug.join('/')} | ||
</h1> | ||
<Widget /> | ||
</> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
'client' | ||
|
||
import { useState, useEffect } from 'react' | ||
|
||
import style from './style.module.css' | ||
import './style.css' | ||
|
||
export default function ClientComponentRoute() { | ||
const [count, setCount] = useState(0) | ||
useEffect(() => { | ||
setCount(1) | ||
}, [count]) | ||
return ( | ||
<> | ||
<p className={style.red}> | ||
hello from app/client-component-route. <b>count: {count}</b> | ||
</p> | ||
</> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
b { | ||
color: blue; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.red { | ||
color: red; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
'client' | ||
|
||
import { useState, useEffect } from 'react' | ||
|
||
import styles from './style.module.css' | ||
import './style.css' | ||
|
||
export default function ClientNestedLayout({ children }) { | ||
const [count, setCount] = useState(0) | ||
useEffect(() => { | ||
setCount(1) | ||
}, []) | ||
return ( | ||
<> | ||
<h1 className={styles.red}>Client Nested. Count: {count}</h1> | ||
<button onClick={() => setCount(count + 1)}>{count}</button> | ||
{children} | ||
</> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default function ClientPage() { | ||
return ( | ||
<> | ||
<p>hello from app/client-nested</p> | ||
</> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
button { | ||
color: red; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.red { | ||
color: red; | ||
} |
7 changes: 7 additions & 0 deletions
7
demos/canary/app/client-with-errors/get-server-side-props/page.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
'client' | ||
|
||
// export function getServerSideProps() { { props: {} } } | ||
ascorbic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
export default function Page() { | ||
return 'client-gssp' | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
'client' | ||
|
||
// export function getStaticProps() { return { props: {} }} | ||
ascorbic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
export default function Page() { | ||
return 'client-gsp' | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.foo { | ||
color: blue; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
body { | ||
background: cyan; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
h1 { | ||
color: red !important; | ||
} | ||
h1::after { | ||
content: ' (from css-client!!!!)'; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import './client-foo.css' | ||
|
||
export default function Foo() { | ||
return <b className="foo">foo</b> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
'client' | ||
ascorbic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
import './client-layout.css' | ||
|
||
import Foo from './foo' | ||
|
||
export default function ServerLayout({ children }) { | ||
return ( | ||
<> | ||
{children} | ||
<Foo /> | ||
</> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
'client' | ||
|
||
import './client-page.css' | ||
|
||
export default function Page() { | ||
return <h1>Page!!!</h1> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
'client' | ||
|
||
import './style.css' | ||
import styles from './style.module.css' | ||
|
||
export default function ClientLayout({ children }) { | ||
return ( | ||
<> | ||
<div className={styles['client-css']}>Client Layout: CSS Modules</div> | ||
<div className="client-css">Client Layout: Global CSS</div> | ||
{children} | ||
</> | ||
) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were there errors or warnings being raised as a result of this not being set within the project? Or is this being introduced for another reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I added that when there were errors building, but it looks like it doesn't need it anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke too soon! https://app.netlify.com/sites/next-plugin-canary/deploys/63400888c5a6620008d11571