Skip to content

Commit 4ca88aa

Browse files
committed
8370852: Test sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java fails after JDK-8369995
Reviewed-by: coffeys, wetmore
1 parent 4913b54 commit 4ca88aa

File tree

2 files changed

+34
-27
lines changed

2 files changed

+34
-27
lines changed

test/jdk/ProblemList.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -637,8 +637,6 @@ sun/security/smartcardio/TestTransmit.java 8039280 generic-
637637

638638
sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java 8316183 linux-ppc64le
639639

640-
sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java 8370852 generic-all
641-
642640
############################################################################
643641

644642
# jdk_sound

test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java

Lines changed: 34 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
/**
2525
* @test
26-
* @bug 8350582 8340312
26+
* @bug 8350582 8340312 8369995
2727
* @library /test/lib /javax/net/ssl/templates
2828
* @summary Correct the parsing of the ssl value in javax.net.debug
2929
* @run junit DebugPropertyValuesTest
@@ -50,24 +50,27 @@
5050
public class DebugPropertyValuesTest extends SSLSocketTemplate {
5151

5252
private static final Path LOG_FILE = Path.of("logging.conf");
53-
private static final HashMap<String, List<String>> debugMessages = new HashMap<>();
53+
private static final HashMap<String, List<String>> debugMessages =
54+
new HashMap<>();
5455
private static final String DATE_REGEX = "\\d{4}-\\d{2}-\\d{2}";
5556

5657
static {
57-
58-
5958
debugMessages.put("handshake",
6059
List.of("Produced ClientHello handshake message",
6160
"supported_versions"));
62-
debugMessages.put("keymanager", List.of("choosing key:"));
61+
debugMessages.put("keymanager", List.of("Choosing key:"));
6362
debugMessages.put("packet", List.of("Raw write"));
64-
debugMessages.put("plaintext", List.of("Plaintext before ENCRYPTION"));
63+
debugMessages.put("plaintext",
64+
List.of("Plaintext before ENCRYPTION"));
6565
debugMessages.put("record", List.of("handshake, length =", "WRITE:"));
6666
debugMessages.put("session", List.of("Session initialized:"));
67-
debugMessages.put("sslctx", List.of("trigger seeding of SecureRandom"));
67+
debugMessages.put("sslctx",
68+
List.of("trigger seeding of SecureRandom"));
6869
debugMessages.put("ssl", List.of("jdk.tls.keyLimits:"));
69-
debugMessages.put("trustmanager", List.of("adding as trusted certificates"));
70-
debugMessages.put("verbose", List.of("Ignore unsupported cipher suite:"));
70+
debugMessages.put("trustmanager",
71+
List.of("adding as trusted certificates"));
72+
debugMessages.put("verbose",
73+
List.of("Ignore unsupported cipher suite:"));
7174
debugMessages.put("handshake-expand",
7275
List.of("\"logger\".*: \"javax.net.ssl\",",
7376
"\"specifics\" : \\[",
@@ -114,15 +117,18 @@ private static Stream<Arguments> patternMatches() {
114117
"record", "session", "ssl",
115118
"sslctx", "trustmanager", "verbose")),
116119
// allow expand option for more verbose output
117-
Arguments.of(List.of("-Djavax.net.debug=ssl,handshake,expand"),
118-
List.of("handshake", "handshake-expand", "keymanager",
119-
"record", "session", "record-expand", "ssl",
120-
"sslctx", "trustmanager", "verbose")),
120+
Arguments.of(
121+
List.of("-Djavax.net.debug=ssl,handshake,expand"),
122+
List.of("handshake", "handshake-expand",
123+
"keymanager", "record", "session",
124+
"record-expand", "ssl", "sslctx",
125+
"trustmanager", "verbose")),
121126
// filtering on record option, with expand
122127
Arguments.of(List.of("-Djavax.net.debug=ssl:record,expand"),
123-
List.of("handshake", "handshake-expand", "keymanager",
124-
"record", "record-expand", "session", "ssl",
125-
"sslctx", "trustmanager", "verbose")),
128+
List.of("handshake", "handshake-expand",
129+
"keymanager", "record", "record-expand",
130+
"session", "ssl", "sslctx", "trustmanager",
131+
"verbose")),
126132
// this test is equivalent to ssl:record mode
127133
Arguments.of(List.of("-Djavax.net.debug=ssl,record"),
128134
List.of("handshake", "keymanager", "record",
@@ -147,30 +153,33 @@ private static Stream<Arguments> patternMatches() {
147153
"record", "session", "ssl",
148154
"sslctx", "trustmanager", "verbose")),
149155
// plaintext is valid for record option
150-
Arguments.of(List.of("-Djavax.net.debug=ssl:record:plaintext"),
156+
Arguments.of(
157+
List.of("-Djavax.net.debug=ssl:record:plaintext"),
151158
List.of("handshake", "keymanager", "plaintext",
152159
"record", "session", "ssl",
153160
"sslctx", "trustmanager", "verbose")),
154161
Arguments.of(List.of("-Djavax.net.debug=ssl:trustmanager"),
155-
List.of("handshake", "keymanager", "record", "session",
156-
"ssl", "sslctx", "trustmanager", "verbose")),
162+
List.of("handshake", "keymanager", "record",
163+
"session", "ssl", "sslctx", "trustmanager",
164+
"verbose")),
157165
Arguments.of(List.of("-Djavax.net.debug=ssl:sslctx"),
158-
List.of("handshake", "keymanager", "record", "session",
159-
"ssl", "sslctx", "trustmanager", "verbose")),
166+
List.of("handshake", "keymanager", "record",
167+
"session", "ssl", "sslctx", "trustmanager",
168+
"verbose")),
160169
// help message test. Should exit without running test
161170
Arguments.of(List.of("-Djavax.net.debug=help"),
162171
List.of("help")),
163172
// add in javax.net.debug sanity test
164173
Arguments.of(List.of("-Djavax.net.debug=ssl:trustmanager",
165174
"-Djava.security.debug=all"),
166-
List.of("handshake", "java.security.debug", "keymanager",
167-
"record", "session", "ssl", "sslctx",
168-
"trustmanager", "verbose")),
175+
List.of("handshake", "java.security.debug",
176+
"keymanager", "record", "session", "ssl",
177+
"sslctx", "trustmanager", "verbose")),
169178
// empty invokes System.Logger use
170179
Arguments.of(List.of("-Djavax.net.debug",
171180
"-Djava.util.logging.config.file=" + LOG_FILE),
172181
List.of("handshake", "javax.net.debug.logger",
173-
"keymanager", "packet", "plaintext",
182+
"keymanager", "packet", "plaintext",
174183
"record", "session", "ssl",
175184
"sslctx", "trustmanager", "verbose"))
176185
);

0 commit comments

Comments
 (0)