Fix profanity filter + new username generator

The profanity filter was fixed up to account for cases like [C]rap and C_rap. The filter was extended slightly, and the `RegExpMatcher` ctor was fixed (transformers can't use the same `...` syntax like `englishDataset` and `englishRecommendedTransformers`

Additionally, the scattered set of name generators used for players was replaced with one single name generator that comes up with some snazzy stuff like "Space Cow", "Secret Gnome Agenda", and "Comically Large Snail".

Copyright: No AI was used in the making of this patch.

Author: Mooshua

src/client/UsernameInput.ts

@@ -7,6 +7,7 @@ import {
   MAX_USERNAME_LENGTH,
   validateUsername,
 } from "../core/validations/username";
+import { getRandomUsername } from "../core/utilities/UsernameGenerator";
 
 const usernameKey: string = "username";
 
@@ -94,7 +95,7 @@ export class UsernameInput extends LitElement {
   }
 
   private generateNewUsername(): string {
-    const newUsername = "Anon" + this.uuidToThreeDigits();
+    const newUsername = getRandomUsername(Math.random())
     this.storeUsername(newUsername);
     return newUsername;
   }

src/core/Util.ts

@@ -12,10 +12,7 @@ import {
   Winner,
 } from "./Schemas";
 
-import {
-  BOT_NAME_PREFIXES,
-  BOT_NAME_SUFFIXES,
-} from "./execution/utils/BotNames";
+import { getRandomUsername } from "./utilities/UsernameGenerator";
 
 export function manhattanDistWrapped(
   c1: Cell,
@@ -276,16 +273,10 @@ export function createRandomName(
   name: string,
   playerType: string,
 ): string | null {
-  let randomName: string | null = null;
   if (playerType === "HUMAN") {
-    const hash = simpleHash(name);
-    const prefixIndex = hash % BOT_NAME_PREFIXES.length;
-    const suffixIndex =
-      Math.floor(hash / BOT_NAME_PREFIXES.length) % BOT_NAME_SUFFIXES.length;
-
-    randomName = `👤 ${BOT_NAME_PREFIXES[prefixIndex]} ${BOT_NAME_SUFFIXES[suffixIndex]}`;
+    return getRandomUsername(simpleHash(name));
   }
-  return randomName;
+  return null;
 }
 
 export const emojiTable = [

src/core/utilities/UsernameGenerator.ts

@@ -0,0 +1,104 @@
+import { simpleHash } from "../Util"
+
+const PLURAL_NOUN = Symbol("plural!")
+const NOUN = Symbol("noun!")
+
+const names = [
+    ["World Famous", NOUN],
+    ["Comically Large", NOUN],
+    ["Comically Small", NOUN],
+    ["Clearance Aisle", PLURAL_NOUN],
+    [NOUN, "For Hire"],
+    ["Suspicious", NOUN],
+    ["Sopping Wet", PLURAL_NOUN],
+    ["Smelly", NOUN],
+    ["Friendly", NOUN],
+    ["Tardy", NOUN],
+    ["Evil", NOUN],
+    [PLURAL_NOUN, "That Bite"],
+    ["Malicious", NOUN],
+    ["Spiteful", NOUN],
+    ["Mister", NOUN],
+    ["Alternate", NOUN,"Universe"],
+    [NOUN, "Island"],
+    [NOUN, "Kingdom"],
+    [NOUN, "Empire"],
+    [NOUN, "Dynasty"],
+    [NOUN, "Cartel"],
+    [NOUN, "Cabal"],
+    ["Not Too Fond Of", PLURAL_NOUN],
+    ["Honk For", PLURAL_NOUN],
+    ["Canonically Evil", NOUN],
+    ["Limited Edition", NOUN],
+    [NOUN, "Scientist"],
+    ["Famous", NOUN, "Collection"],
+    ["Supersonic", NOUN, "Spaceship"],
+    ["Patent Pending", NOUN],
+    ["Patented", NOUN],
+    ["Space", NOUN],
+    ["Secret", NOUN, "Agenda"],
+    [PLURAL_NOUN, "in my walls"],
+    ["The", PLURAL_NOUN, "are SPIES"],
+    ["Traveling", NOUN, "Circus"]
+]
+
+const nouns = [
+    "Snail",
+    "Cow",
+    "Giraffe",
+    "Donkey",
+    "Horse",
+    "Mushroom",
+    "Salad",
+    "Kitten",
+    "Fork",
+    "Apple",
+    "Pancake",
+    "Tree",
+    "Fern",
+    "Seashell",
+    "Turtle",
+    "Casserole",
+    "Gnome",
+    "Frog",
+]
+
+function isSeedAcceptable(sanitizedSeed: number) {
+    let template = names[sanitizedSeed % names.length];
+    let noun = nouns[Math.floor(sanitizedSeed / names.length) % nouns.length];
+
+    let totalLength = 
+        template.map((v) => ((v as any)?.length ?? 0)).reduce((a,b) => a + b)
+        + template.length
+        + noun.length;
+
+    return totalLength <= 26
+}
+/**
+ * Generate a random username based on a numeric seed
+ * @param seed - the seed to use to select a username
+ * @returns a string suitable for a player username
+ */
+export function getRandomUsername(seed: number) : string {
+    let sanitizedSeed = Math.floor((seed * 2999) % (names.length * nouns.length));
+    let template = names[sanitizedSeed % names.length];
+    let noun = nouns[Math.floor(sanitizedSeed / names.length) % nouns.length];
+    let result: [string?] = [];
+
+    while (!isSeedAcceptable(sanitizedSeed)) {
+        sanitizedSeed += 1;
+    }
+
+    //  Convert template to some somewhat-legible word string
+    for (let step of template) {
+        if (step == PLURAL_NOUN) {
+            result.push(`${noun}s`);
+        } else if (step == NOUN) {
+            result.push(noun);
+        } else {
+            result.push(step.toString());
+        }
+    }
+
+    return result.join(" ")
+}

src/core/validations/username.ts

@@ -1,22 +1,45 @@
 import {
+  DataSet,
   RegExpMatcher,
   collapseDuplicatesTransformer,
   englishDataset,
-  englishRecommendedTransformers,
+  pattern,
   resolveConfusablesTransformer,
   resolveLeetSpeakTransformer,
   skipNonAlphabeticTransformer,
+  toAsciiLowerCaseTransformer,
 } from "obscenity";
 import { translateText } from "../../client/Utils";
 import { simpleHash } from "../Util";
+import { getRandomUsername } from "../utilities/UsernameGenerator";
+
+const customDataset = new DataSet()
+  .addAll(englishDataset)
+  .addPhrase((phrase) => 
+    phrase.setMetadata({ originalWord: 'nigg' })
+    /* Not used by any english words */
+    .addPattern(pattern`niqq`))
 
 const matcher = new RegExpMatcher({
-  ...englishDataset.build(),
-  ...englishRecommendedTransformers,
-  ...resolveConfusablesTransformer(),
-  ...skipNonAlphabeticTransformer(),
-  ...collapseDuplicatesTransformer(),
-  ...resolveLeetSpeakTransformer(),
+  ...customDataset.build(),
+
+  blacklistMatcherTransformers: [
+    resolveConfusablesTransformer(),
+    resolveLeetSpeakTransformer(),
+    skipNonAlphabeticTransformer(),
+    toAsciiLowerCaseTransformer(),
+    collapseDuplicatesTransformer({
+    customThresholds: new Map([
+      ['b', 2],
+      ['e', 2],
+      ['o', 2],
+      ['l', 2],
+      ['s', 2],
+      ['g', 2],
+      ['q', 2]
+    ]),
+  })
+  ]
 });
 
 export const MIN_USERNAME_LENGTH = 3;
@@ -36,7 +59,7 @@ const shadowNames = [
 
 export function fixProfaneUsername(username: string): string {
   if (isProfaneUsername(username)) {
-    return shadowNames[simpleHash(username) % shadowNames.length];
+    return getRandomUsername(simpleHash(username));
   }
   return username;
 }